Profile snapshot id payload #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fixes #214 +/- ##
=======================================
- Coverage 97.4% 97.4% -0.1%
=======================================
Files 941 942 +1
Lines 15077 15105 +28
Branches 70 70
=======================================
+ Hits 14700 14727 +27
- Misses 367 368 +1
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jvm/sargon-android/src/test/java/com/radixdlt/sargon/SecureStorageKeyTest.kt
Outdated
Show resolved
Hide resolved
CyonAlexRDX
reviewed
Sep 18, 2024
crates/sargon/src/system/drivers/secure_storage_driver/support/secure_storage_key.rs
Outdated
Show resolved
Hide resolved
CyonAlexRDX
approved these changes
Sep 18, 2024
micbakos-rdx
pushed a commit
that referenced
this pull request
Sep 27, 2024
* wip * wip * fix test * wip * fix ios tests * test * update * wip
micbakos-rdx
pushed a commit
that referenced
this pull request
Sep 30, 2024
* wip * wip * fix test * wip * fix ios tests * test * update * wip
GhenadieVP
added a commit
that referenced
this pull request
Sep 30, 2024
* Replace kotlin base64 with android base 64 and mock it in unit tests * Make profileStateChanges a shared flow * Remove planting of debug tree * Print errors with timber in example app too * Fix example profile states * Remove checks before asking for biometrics * Suspend request for biometrics until activity is at least started * Report secure storage access error * Make read and write methods public * Make encrypt and decrypt methods public * Implement function to remove a list of keyspecs * Make generateSecretKey public for now * Add error kind for biometrics failure * Export method to derive profile based on bdfs and some accounts * Emit derived profile in profile state change * Store profile state into android state change driver * Make reset keyspec method to regenerate a new key when fail * Included SargonOsManager into sargon android * Make drivers explicit * Replace with new_wallet_with_derived_bdfs * Change doc * Allow set profile to set one profile when none exists * Change iOS test * Fix android test * Fix set_profile to notify ProfileStateChange client about the latest mutated profile * Fix content hint to report correct total amount of personas * Create initial profile with no networks * Delete ephemeral profile when booting * Return error when network does not yet exist * Profile snapshot id payload (#214) * wip * wip * fix test * wip * fix ios tests * test * update * wip * Bump cargo version * Profile safe concurrent access (#225) * wip * fix * fix * wip * wip * wip --------- Co-authored-by: Ghenadie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the profile id as part of ProfileSnapshot secure storage key. This is needed so the iOS wallet has the profile id when needing to save the profile data. It is meant to be ignored for other usages.