Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ResourcePreferences under ProfileNetwork #209

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

matiasbzurovski
Copy link
Contributor

Changelog

  • Place the ResourcePreferences under ProfileNetwork

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.4%. Comparing base (284c16b) to head (cb97663).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../sargon/src/system/sargon_os/sargon_os_accounts.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #209     +/-   ##
=======================================
- Coverage   97.4%   97.4%   -0.1%     
=======================================
  Files        932     932             
  Lines      14934   14965     +31     
  Branches      64      64             
=======================================
+ Hits       14553   14583     +30     
- Misses       374     375      +1     
  Partials       7       7             
Flag Coverage Δ
rust 96.9% <98.1%> (-0.1%) ⬇️
swift 99.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ic/profile_network/profile_network_get_entities.rs 100.0% <ø> (ø)
...rc/profile/v100/app_preferences/app_preferences.rs 100.0% <100.0%> (ø)
...c/profile/v100/networks/network/profile_network.rs 100.0% <100.0%> (ø)
...s/network/resource_preferences/hidden_resources.rs 100.0% <ø> (ø)
...rk/resource_preferences/resource_app_preference.rs 100.0% <100.0%> (ø)
...etwork/resource_preferences/resource_identifier.rs 100.0% <100.0%> (ø)
...twork/resource_preferences/resource_preferences.rs 100.0% <100.0%> (ø)
...urce_preferences/resource_preferences_uniffi_fn.rs 100.0% <ø> (ø)
...etwork/resource_preferences/resource_visibility.rs 100.0% <ø> (ø)
...rgon/src/profile/v100/networks/profile_networks.rs 100.0% <ø> (ø)
... and 3 more

.get_all()
.into_iter()
.all(|d| d.network_id() == network_id),
"Discrepancy, found a ResourceAppPreference on other network than {network_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing test (as highlighted by CodeCov)

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasbzurovski matiasbzurovski merged commit 2d0cdb3 into main Sep 5, 2024
9 of 10 checks passed
@matiasbzurovski matiasbzurovski deleted the mb/move-resource-preferences branch September 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants