-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ResourcePreferences under ProfileNetwork #209
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
=======================================
- Coverage 97.4% 97.4% -0.1%
=======================================
Files 932 932
Lines 14934 14965 +31
Branches 64 64
=======================================
+ Hits 14553 14583 +30
- Misses 374 375 +1
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
.get_all() | ||
.into_iter() | ||
.all(|d| d.network_id() == network_id), | ||
"Discrepancy, found a ResourceAppPreference on other network than {network_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing test (as highlighted by CodeCov)
64deafe
to
5d186c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog
ResourcePreferences
underProfileNetwork