Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap RET Addresses #10

Merged
merged 52 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
eedf6a2
Arithmetic operations for Decimal
Sajjon Feb 13, 2024
d4a019a
Decimal compare methods and UniFFI exported funtions
Sajjon Feb 13, 2024
ed6e18e
add Swift bindgen tests for decimal
Sajjon Feb 14, 2024
2e95bfb
Merge branch 'develop' into wrap_radix_engine_toolkit
Sajjon Feb 14, 2024
30f134d
Sargon: Add method to read Mnemonic, UniFFI exported, Improve iOS exa…
Sajjon Feb 16, 2024
2c447c5
Merge
Sajjon Feb 17, 2024
944795e
WIP Decimal192 + Swifitfied
Sajjon Feb 17, 2024
a9b96d0
Make Decimal192 conform to Comparable
Sajjon Feb 17, 2024
5ec79b6
Add clamped
Sajjon Feb 17, 2024
ff8a4a4
Decimal rounding
Sajjon Feb 17, 2024
ac0e057
rename file decimal -> decimal192.rs, add from f32.
Sajjon Feb 17, 2024
3dc5907
Add from_formatted_string
Sajjon Feb 18, 2024
b2c90d9
Swiftify Decimal192 from formatted string
Sajjon Feb 18, 2024
47f6da9
Add tests
Sajjon Feb 18, 2024
7592b04
more tests
Sajjon Feb 18, 2024
9437497
Start stubbing out Signatures and other types required by RET, which …
Sajjon Feb 19, 2024
5f5cc20
Declare Ed25519Signature and use it with Ed25519PrivateKey and Public…
Sajjon Feb 19, 2024
fe86e8c
drop Ord/PartialOrd for types where it did not really make sense. Rem…
CyonAlexRDX Feb 19, 2024
9aad4ff
Add HasPlaceholder conformance to Ed25519PublicKey
Sajjon Feb 19, 2024
b31d4fa
Add HasPlaceholder conformance to Secp256k1Signature
Sajjon Feb 19, 2024
1731692
tests of Ed25519Signature and Secp256k1Signature
CyonAlexRDX Feb 19, 2024
3d286fc
Unit tests for Signature
CyonAlexRDX Feb 19, 2024
6a7efd4
Merge branch 'develop' into wrap_radix_engine_toolkit
CyonAlexRDX Feb 19, 2024
95931b9
Add step to precommit ensuring that local development is set to false…
CyonAlexRDX Feb 19, 2024
32e15fb
fail fast in precommit
CyonAlexRDX Feb 19, 2024
edd3748
build, here is the updated Swift bindgen
CyonAlexRDX Feb 19, 2024
526e887
address WIP
Sajjon Feb 20, 2024
c21494b
WIP wrap RET addresses
Sajjon Feb 20, 2024
0623404
WIP wrapping addresses with macro
Sajjon Feb 20, 2024
24f5327
WIP addresses
Sajjon Feb 20, 2024
70eb41e
WIP: letting macro expose address methods as global freestanding func…
CyonAlexRDX Feb 20, 2024
342b52a
Placeholder values for Pool and Component
CyonAlexRDX Feb 20, 2024
4955e21
WIP: addressesm JSON roundtrop fails for addresses
CyonAlexRDX Feb 20, 2024
4f4c140
fix UniFFI bindgen tests
Sajjon Feb 20, 2024
18df193
merge
Sajjon Feb 20, 2024
d4e4343
Add is_legacy to account address, and is_fungible to ResourceAddress …
Sajjon Feb 20, 2024
73a1c04
Upgrade RET to Sajjons commit containing fix including Zabanet in RET.
Sajjon Feb 21, 2024
4d933dc
Hide the following holder from Swift SPM: src, tests, scripts, exampl…
Sajjon Feb 21, 2024
8075d47
simplify Decimal192, there was in fact no need for a InnerDecimal typ…
Sajjon Feb 21, 2024
535f5b4
Document ALL Address types - Simplify wrapping of RET Addresses by re…
Sajjon Feb 21, 2024
cdd598f
Swiftify all address types
Sajjon Feb 21, 2024
4ca2f3d
more tests
Sajjon Feb 21, 2024
e431827
revert Vstack
Sajjon Feb 21, 2024
7177afa
simplify addresses
CyonAlexRDX Feb 21, 2024
2a6a34a
moar tests
Sajjon Feb 21, 2024
9c577a9
codecov accuracy
Sajjon Feb 21, 2024
d167ab9
Oops, Forgot to use the doc string for address types, now fixed.
Sajjon Feb 21, 2024
1b9f7d1
Test debug of Addresses
Sajjon Feb 21, 2024
74352b9
git rm and gitignore apple/Sources/UniFFI/Sargon.swift
Sajjon Feb 21, 2024
4080391
Moar tests
Sajjon Feb 21, 2024
43e257c
try increase accuracy
Sajjon Feb 21, 2024
f606f4c
moar tests
Sajjon Feb 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# Attention! This is the HEART of iOS, ignoring it leads to better
# PR since less noisy Lines of Code change delta, and smaller git
# history. And we CAN ignore it because:
# CD will add and commit it and tag that commit and push it to GH releases,
# so the file is updated and included in releases, so will work with SPM.
# And locally, when we run `./scripts/ios/build-sargon.sh` the file gets
# updated to something runnable and we can run locally... So we never need
# this file part of git history.
apple/Sources/UniFFI/Sargon.swift

/target
tarpaulin-report.html
.vscode
Expand Down
23 changes: 0 additions & 23 deletions BuildProcess.md

This file was deleted.

9 changes: 6 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ serde_repr = "0.1.17"
strum = { version = "0.25.0", features = ["derive"] }
strum_macros = { version = "0.26.1" }

# 587d5988cd4ca3c5193ddf37027ff4e4ecd637dc is the Scrypto commit that RET 9dc3deeb3299b4f4c255f36bb3d504681379ad5a uses
# 587d5988cd4ca3c5193ddf37027ff4e4ecd637dc is the Scrypto commit that RET e0e79548e71066d7569f8871c5b002fd5805d9d5 uses
radix-engine-common = { git = "https://github.com/radixdlt/radixdlt-scrypto", rev = "587d5988cd4ca3c5193ddf37027ff4e4ecd637dc", features = [
"serde",
] }
radix-engine-interface = { git = "https://github.com/radixdlt/radixdlt-scrypto", rev = "587d5988cd4ca3c5193ddf37027ff4e4ecd637dc", features = [
"std",
] }
radix-engine-toolkit-json = { git = "https://github.com/radixdlt/radix-engine-toolkit", rev = "9dc3deeb3299b4f4c255f36bb3d504681379ad5a" }
radix-engine-toolkit = { git = "https://github.com/radixdlt/radix-engine-toolkit", rev = "9dc3deeb3299b4f4c255f36bb3d504681379ad5a" }
radix-engine-toolkit-json = { git = "https://github.com/radixdlt/radix-engine-toolkit", rev = "e0e79548e71066d7569f8871c5b002fd5805d9d5" }
radix-engine-toolkit = { git = "https://github.com/radixdlt/radix-engine-toolkit", rev = "e0e79548e71066d7569f8871c5b002fd5805d9d5" }
enum-iterator = "1.4.1"
bip32 = "0.5.1" # only need Secp256k1, to do validation of PublicKey
ed25519-dalek = "1.0.1"
Expand All @@ -69,6 +69,7 @@ time-util = { version = "0.3.4", features = ["chrono"] }
assert-json-diff = "2.0.2"
url = { version = "2.5.0", features = ["serde"] }
num-format = "0.4.4"
paste = "1.0.14"

[build-dependencies]
uniffi = { version = "0.26.0", features = ["build"] }
Expand Down
3 changes: 2 additions & 1 deletion _typos.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ extend-exclude = [

[default.extend-identifiers]
inout = "inout"
pool_tdx_2_1c4ml86h8lvfk7jma0jy0vksh8srcxhmtax8nd3aur29qtd2k2wmlzk = "pool_tdx_2_1c4ml86h8lvfk7jma0jy0vksh8srcxhmtax8nd3aur29qtd2k2wmlzk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos CLI tool corrected that address 😅😅 so had to ignore it


[default.extend-words]
inout = "inout"
inout = "inout"
Loading
Loading