Skip to content

Commit

Permalink
Make sure Release script in fact commits before tagging, otherwise ta…
Browse files Browse the repository at this point in the history
…gging is meaningless, CD did not work because the released tag did not contain the updated checksum and path in Package.swift (since we did not commit before tagging...).
  • Loading branch information
Sajjon committed Feb 20, 2024
1 parent 73af6c9 commit 3b991ab
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/ios/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ XCFRAME_ZIP_PATH=`echo "$OUTPUT_OF_BUILD" | cut -d ";" -f 2` || exit $?

echo "🚢 CHECKSUM: $CHECKSUM"
echo "🚢 XCFRAME_ZIP_PATH: $XCFRAME_ZIP_PATH"

`git commit -m "Release of '$NEXT_TAG' (updated Package.swift with new checksum and path to zip on Github). This commit is not merged into main/develop branch (and need not be)."`
`git tag $NEXT_TAG`
echo "🚢 🏷️ 📡 Pushing tag: $(last_tag)"
echo "🚢 🏷️ 📡 Pushing tag: $(NEXT_TAG), but only tag, not commit."
`git push origin $NEXT_TAG`

# This MUST match whatever you we have declared in `$PROJECT_ROOT/Package.swift`
Expand Down

0 comments on commit 3b991ab

Please sign in to comment.