Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Add radiswap-v2 scenario to demonstrate blueprint linking #2068

Merged
merged 6 commits into from
Feb 18, 2025
Merged

tests: Add radiswap-v2 scenario to demonstrate blueprint linking #2068

merged 6 commits into from
Feb 18, 2025

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Feb 14, 2025 •
edited
Loading

Summary

Adds a radiswap_v2 scenario, primarily for Gateway testing, which will be auto-executed at Dugong.

(Will pull Dugong into the node next)

Testing

The scenario is run as part of the dumper test.

Changelog

The changelog has been updated to capture the change.

@dhedey dhedey requested a review from a team as a code owner February 14, 2025 14:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Docker tags
docker.io/radixdlt/private-scrypto-dev-container:a2cafc823e

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Docker tags
docker.io/radixdlt/private-scrypto-builder:a2cafc823e

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Benchmark for a2cafc8

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.7±0.08ms 44.6±0.08ms -0.22%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.8±0.05ms 19.6±0.01ms -1.01%
costing::decode_encoded_i8_array_to_manifest_value 41.7±0.07ms 41.4±0.12ms -0.72%
costing::decode_encoded_tuple_array_to_manifest_raw_value 71.1±0.11ms 71.3±0.21ms +0.28%
costing::decode_encoded_tuple_array_to_manifest_value 106.0±0.14ms 98.2±0.09ms -7.36%
costing::decode_encoded_u8_array_to_manifest_raw_value 26.2±0.08µs 31.9±0.09µs +21.76%
costing::decode_encoded_u8_array_to_manifest_value 41.6±0.06ms 41.3±0.05ms -0.72%
costing::decode_rpd_to_manifest_raw_value 14.7±0.07µs 14.5±0.02µs -1.36%
costing::decode_rpd_to_manifest_value 10.9±0.03µs 10.8±0.01µs -0.92%
costing::deserialize_wasm 1201.7±2.12µs 1215.6±17.32µs +1.16%
costing::execute_transaction_creating_big_vec_substates 702.9±11.90ms 694.2±8.10ms -1.24%
costing::execute_transaction_reading_big_vec_substates 603.4±2.16ms 602.1±0.92ms -0.22%
costing::instantiate_flash_loan 825.3±89.09µs 1028.8±1225.53µs +24.66%
costing::instantiate_radiswap 1037.8±952.92µs 1275.6±3003.64µs +22.91%
costing::scrypto_malloc 700.8±1.48ms 646.4±1.91ms -7.76%
costing::scrypto_sbor_decode 687.2±1.13ms 653.6±1.25ms -4.89%
costing::scrypto_sha256 605.8±1.19ms 584.3±0.75ms -3.55%
costing::spin_loop_v1 584.6±2.90ms 542.5±0.82ms -7.20%
costing::spin_loop_v2 598.2±2.21ms 598.0±1.04ms -0.03%
costing::validate_sbor_payload 29.5±0.08µs 28.8±0.04µs -2.37%
costing::validate_sbor_payload_bytes 248.3±0.61ns 257.1±0.48ns +3.54%
costing::validate_secp256k1 76.7±0.10µs 76.6±0.06µs -0.13%
costing::validate_wasm 33.6±0.04ms 33.6±0.04ms 0.00%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.9±0.00ns 9.8±0.00ns -1.01%
decimal::add/wasmi 317.0±2.53ns 326.1±2.32ns +2.87%
decimal::add/wasmi-call-native 3.0±0.00µs 2.9±0.01µs -3.33%
decimal::div/0 168.8±0.36ns 168.5±0.13ns -0.18%
decimal::from_string/0 155.2±0.16ns 155.9±0.28ns +0.45%
decimal::mul/0 129.8±0.17ns 129.1±0.06ns -0.54%
decimal::mul/rust-native 125.3±0.12ns 125.4±0.17ns +0.08%
decimal::mul/wasmi 19.2±0.12µs 20.2±0.14µs +5.21%
decimal::mul/wasmi-call-native 3.1±0.00µs 3.0±0.01µs -3.23%
decimal::pow/0 594.7±0.43ns 594.0±0.39ns -0.12%
decimal::pow/rust-native 588.2±0.75ns 588.3±0.96ns +0.02%
decimal::pow/wasmi 92.8±0.20µs 90.2±0.37µs -2.80%
decimal::pow/wasmi-call-native 4.7±0.02µs 4.7±0.01µs 0.00%
decimal::root/0 8.0±0.00µs 8.1±0.00µs +1.25%
decimal::sub/0 8.1±0.02ns 8.1±0.01ns 0.00%
decimal::to_string/0 440.5±0.31ns 439.2±0.20ns -0.30%
large_transaction_processing::prepare 2.4±0.00ms 2.5±0.00ms +4.17%
large_transaction_processing::prepare_and_decompile 6.1±0.04ms 6.0±0.03ms -1.64%
large_transaction_processing::prepare_and_decompile_and_recompile 30.3±1.79ms 24.6±0.08ms -18.81%
metadata_validation::validate_urls 4.7±0.01µs 4.8±0.04µs +2.13%
precise_decimal::add/0 9.1±0.01ns 9.0±0.05ns -1.10%
precise_decimal::add/rust-native 10.8±0.03ns 10.8±0.01ns 0.00%
precise_decimal::add/wasmi 422.5±1.99ns 454.5±2.43ns +7.57%
precise_decimal::add/wasmi-call-native 3.8±0.00µs 3.9±0.00µs +2.63%
precise_decimal::div/0 295.3±1.16ns 299.0±1.52ns +1.25%
precise_decimal::from_string/0 203.5±0.19ns 203.2±0.06ns -0.15%
precise_decimal::mul/0 331.4±0.35ns 336.8±1.42ns +1.63%
precise_decimal::mul/rust-native 289.5±0.33ns 290.1±0.81ns +0.21%
precise_decimal::mul/wasmi 49.2±0.26µs 48.2±0.16µs -2.03%
precise_decimal::mul/wasmi-call-native 4.2±0.00µs 4.2±0.01µs 0.00%
precise_decimal::pow/0 1748.6±1.81ns 1728.2±2.10ns -1.17%
precise_decimal::pow/rust-native 1378.6±1.90ns 1379.2±2.61ns +0.04%
precise_decimal::pow/wasmi 235.4±0.60µs 229.9±1.31µs -2.34%
precise_decimal::pow/wasmi-call-native 7.4±0.02µs 7.6±0.02µs +2.70%
precise_decimal::root/0 59.2±0.14µs 58.1±0.05µs -1.86%
precise_decimal::sub/0 9.2±0.05ns 9.2±0.01ns 0.00%
precise_decimal::to_string/0 698.3±1.69ns 723.0±1.86ns +3.54%
schema::validate_payload 383.3±0.41µs 387.2±0.42µs +1.02%
transaction::radiswap 5.1±0.02ms 5.0±0.03ms -1.96%
transaction::transfer 1846.6±5.42µs 1828.6±4.93µs -0.97%
transaction_validation::validate_manifest 43.2±0.05µs 43.1±0.06µs -0.23%
transaction_validation::verify_bls_2KB 1006.0±9.76µs 1079.7±25.92µs +7.33%
transaction_validation::verify_bls_32B 1001.6±6.40µs 1002.0±6.75µs +0.04%
transaction_validation::verify_ecdsa 74.6±0.07µs 74.6±0.14µs 0.00%
transaction_validation::verify_ed25519 42.4±0.09µs 45.5±0.07µs +7.31%

@dhedey dhedey changed the title tests: Add radiswap-v2 scenario base tests: Add radiswap-v2 scenario to demonstrate blueprint linking Feb 14, 2025
@dhedey dhedey changed the title tests: Add radiswap-v2 scenario to demonstrate blueprint linking tests: Add radiswap-v2 scenario to demonstrate blueprint linking Feb 14, 2025
@dhedey dhedey requested a review from a team as a code owner February 14, 2025 16:36
@dhedey dhedey mentioned this pull request Feb 14, 2025
Merged
dhedey
dhedey commented Feb 14, 2025
View reviewed changes
scrypto-compiler/tests/assets/call_indirect/Cargo.lock
@@ -239,9 +239,9 @@ checksum = "d2fabcfbdc87f4758337ca535fb41a6d701b65693ce38287d856d1674551ec9b"

[[package]]
name = "hashbrown"
version = "0.15.0"
version = "0.15.2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to fix the remaining dependabot warning

@dhedey dhedey mentioned this pull request Feb 14, 2025
Open
dhedey
dhedey commented Feb 17, 2025
View reviewed changes
radix-transactions/src/builder/manifest_builder.rs
@@ -799,9 +799,9 @@ where
track_total_supply,
non_fungible_schema:
NonFungibleDataSchema::new_local_without_self_package_replacement::<V>(),
entries,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ordered to align with the underlying struct/SBOR ordering for clarity of people looking at source code

@dhedey dhedey merged commit 623e35a into develop Feb 18, 2025
33 checks passed
dhedey added a commit to radixdlt/babylon-node that referenced this pull request Feb 19, 2025
@dhedey
Add dugong protocol update (#1059)
9cecaff 
## Summary

Adds support for the WIP dugong protocol update, with a tag pointing at
the tip of radixdlt/radixdlt-scrypto#2068

You'll need to wipe your dev database to run it, as it attempts to run
Dugong right after Cuttlefish part 2.

## Testing

A test checks that Dugong enacts with default testing config.

## Changelog

Updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamyulong iamyulong iamyulong approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhedey @iamyulong