Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add secrets to crate token #2046

Merged
merged 1 commit into from
Jan 8, 2025
Merged

ci: Add secrets to crate token #2046

merged 1 commit into from
Jan 8, 2025

Conversation

alpeto9
Copy link
Contributor

@alpeto9 alpeto9 commented Jan 7, 2025

Summary

  • Mask AWS role and secret for crates on Github Workflow

@alpeto9 alpeto9 requested review from dhedey, iamyulong and a team January 7, 2025 15:18
Copy link

github-actions bot commented Jan 7, 2025

Docker tags
docker.io/radixdlt/private-scrypto-dev-container:08895fd80e

Copy link

github-actions bot commented Jan 7, 2025

Docker tags
docker.io/radixdlt/private-scrypto-builder:08895fd80e

Copy link

github-actions bot commented Jan 7, 2025

Benchmark for 08895fd

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.6±0.08ms 44.4±0.10ms -0.45%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.3±0.03ms 19.3±0.01ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 40.6±0.06ms 42.0±0.09ms +3.45%
costing::decode_encoded_tuple_array_to_manifest_raw_value 70.6±0.19ms 72.2±0.17ms +2.27%
costing::decode_encoded_tuple_array_to_manifest_value 117.0±1.18ms 121.3±1.23ms +3.68%
costing::decode_encoded_u8_array_to_manifest_raw_value 26.2±0.06µs 32.3±0.14µs +23.28%
costing::decode_encoded_u8_array_to_manifest_value 40.7±0.08ms 42.0±0.05ms +3.19%
costing::decode_rpd_to_manifest_raw_value 14.6±0.04µs 14.4±0.03µs -1.37%
costing::decode_rpd_to_manifest_value 11.1±0.03µs 10.8±0.05µs -2.70%
costing::deserialize_wasm 1217.6±4.03µs 1226.7±7.17µs +0.75%
costing::execute_transaction_creating_big_vec_substates 691.1±4.38ms 702.7±9.96ms +1.68%
costing::execute_transaction_reading_big_vec_substates 567.8±0.35ms 613.6±1.31ms +8.07%
costing::instantiate_flash_loan 1019.2±1190.80µs 911.8±601.70µs -10.54%
costing::instantiate_radiswap 924.2±684.55µs 1050.0±1225.61µs +13.61%
costing::scrypto_malloc 696.8±2.24ms 699.7±1.55ms +0.42%
costing::scrypto_sbor_decode 674.8±1.26ms 674.6±2.95ms -0.03%
costing::scrypto_sha256 599.1±1.39ms 598.5±1.04ms -0.10%
costing::spin_loop_v1 517.5±1.51ms 512.7±0.74ms -0.93%
costing::spin_loop_v2 601.9±1.76ms 604.0±1.61ms +0.35%
costing::validate_sbor_payload 29.3±0.16µs 30.3±0.05µs +3.41%
costing::validate_sbor_payload_bytes 250.3±0.48ns 252.1±0.54ns +0.72%
costing::validate_secp256k1 76.6±0.25µs 76.7±0.13µs +0.13%
costing::validate_wasm 33.6±0.04ms 33.4±0.03ms -0.60%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 317.9±0.57ns 315.6±1.50ns -0.72%
decimal::add/wasmi-call-native 3.0±0.00µs 2.9±0.02µs -3.33%
decimal::div/0 174.8±0.21ns 168.6±0.12ns -3.55%
decimal::from_string/0 156.2±0.12ns 156.8±0.28ns +0.38%
decimal::mul/0 128.5±0.11ns 128.5±0.06ns 0.00%
decimal::mul/rust-native 126.6±0.06ns 128.2±0.08ns +1.26%
decimal::mul/wasmi 19.3±0.05µs 19.0±0.05µs -1.55%
decimal::mul/wasmi-call-native 3.1±0.01µs 3.0±0.02µs -3.23%
decimal::pow/0 591.6±0.17ns 602.4±0.38ns +1.83%
decimal::pow/rust-native 591.6±0.36ns 589.8±0.41ns -0.30%
decimal::pow/wasmi 90.8±0.19µs 93.1±0.17µs +2.53%
decimal::pow/wasmi-call-native 4.8±0.01µs 4.8±0.01µs 0.00%
decimal::root/0 8.0±0.00µs 8.1±0.00µs +1.25%
decimal::sub/0 8.2±0.00ns 8.4±0.01ns +2.44%
decimal::to_string/0 443.4±0.93ns 443.3±0.65ns -0.02%
large_transaction_processing::prepare 2.6±0.00ms 2.5±0.00ms -3.85%
large_transaction_processing::prepare_and_decompile 6.1±0.03ms 6.2±0.03ms +1.64%
large_transaction_processing::prepare_and_decompile_and_recompile 24.7±0.07ms 31.6±0.28ms +27.94%
metadata_validation::validate_urls 4.8±0.04µs 4.8±0.02µs 0.00%
precise_decimal::add/0 8.9±0.01ns 8.9±0.02ns 0.00%
precise_decimal::add/rust-native 10.7±0.02ns 10.8±0.11ns +0.93%
precise_decimal::add/wasmi 429.1±1.34ns 422.2±1.51ns -1.61%
precise_decimal::add/wasmi-call-native 3.9±0.00µs 3.9±0.02µs 0.00%
precise_decimal::div/0 299.1±1.02ns 299.5±2.61ns +0.13%
precise_decimal::from_string/0 201.9±0.15ns 201.6±0.17ns -0.15%
precise_decimal::mul/0 340.5±1.68ns 339.6±1.71ns -0.26%
precise_decimal::mul/rust-native 287.2±0.23ns 286.1±0.53ns -0.38%
precise_decimal::mul/wasmi 47.6±0.15µs 47.5±0.13µs -0.21%
precise_decimal::mul/wasmi-call-native 4.3±0.01µs 4.3±0.01µs 0.00%
precise_decimal::pow/0 1780.0±2.62ns 1780.6±2.35ns +0.03%
precise_decimal::pow/rust-native 1371.9±0.71ns 1360.4±1.15ns -0.84%
precise_decimal::pow/wasmi 226.3±0.26µs 228.7±0.89µs +1.06%
precise_decimal::pow/wasmi-call-native 7.5±0.02µs 7.6±0.01µs +1.33%
precise_decimal::root/0 58.6±0.07µs 58.4±0.05µs -0.34%
precise_decimal::sub/0 9.2±0.05ns 9.2±0.00ns 0.00%
precise_decimal::to_string/0 715.4±0.55ns 692.7±0.65ns -3.17%
schema::validate_payload 383.5±0.48µs 381.2±0.80µs -0.60%
transaction::radiswap 5.0±0.03ms 4.9±0.02ms -2.00%
transaction::transfer 1818.3±2.49µs 1815.9±10.48µs -0.13%
transaction_validation::validate_manifest 43.4±0.07µs 43.2±0.19µs -0.46%
transaction_validation::verify_bls_2KB 1006.1±17.73µs 1005.9±17.83µs -0.02%
transaction_validation::verify_bls_32B 1006.9±17.87µs 1057.1±36.49µs +4.99%
transaction_validation::verify_ecdsa 74.6±0.05µs 75.8±0.12µs +1.61%
transaction_validation::verify_ed25519 50.0±0.08µs 42.2±0.26µs -15.60%

@alpeto9 alpeto9 merged commit 2b8e879 into main Jan 8, 2025
33 checks passed
alpeto9 added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants