Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Markups for #1910, and some auth-zone neatenings #1999

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Nov 11, 2024

Summary

Covers mark-ups for:

  • #1910 - done
    • Includes adding some more docs
    • Includes adding some clearer versioned logic branches, and some field renames
    • Includes adding some related docs and variable naming to the new AuthZone method which I noticed as I worked on the other bits

Markups for all these will follow in a separate PR (but may not make RC.1)

Copy link

github-actions bot commented Nov 11, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:52f9f9a0af

Copy link

github-actions bot commented Nov 11, 2024

Benchmark for 52f9f9a

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.3±0.35ms 45.1±0.19ms +1.81%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.09ms 19.4±0.07ms -1.02%
costing::decode_encoded_i8_array_to_manifest_value 41.9±0.13ms 42.8±0.26ms +2.15%
costing::decode_encoded_tuple_array_to_manifest_raw_value 63.3±0.08ms 61.2±0.10ms -3.32%
costing::decode_encoded_tuple_array_to_manifest_value 99.9±0.35ms 105.9±0.45ms +6.01%
costing::decode_encoded_u8_array_to_manifest_raw_value 25.7±0.06µs 32.0±0.13µs +24.51%
costing::decode_encoded_u8_array_to_manifest_value 42.0±0.15ms 42.7±0.22ms +1.67%
costing::decode_rpd_to_manifest_raw_value 12.3±0.02µs 12.8±0.01µs +4.07%
costing::decode_rpd_to_manifest_value 11.2±0.08µs 10.8±0.02µs -3.57%
costing::deserialize_wasm 1203.4±7.28µs 1239.1±2.73µs +2.97%
costing::execute_transaction_creating_big_vec_substates 715.8±14.74ms 713.4±10.23ms -0.34%
costing::execute_transaction_reading_big_vec_substates 601.4±5.08ms 614.0±4.35ms +2.10%
costing::instantiate_flash_loan 1019.0±1031.85µs 952.4±1047.56µs -6.54%
costing::instantiate_radiswap 1072.0±1392.04µs 993.1±944.50µs -7.36%
costing::scrypto_malloc 486.5±0.64ms 489.8±0.59ms +0.68%
costing::scrypto_sbor_decode 516.1±1.03ms 522.4±1.86ms +1.22%
costing::scrypto_sha256 435.3±1.35ms 438.3±2.63ms +0.69%
costing::spin_loop_v1 432.9±1.39ms 437.3±0.56ms +1.02%
costing::spin_loop_v2 534.8±3.55ms 543.3±4.18ms +1.59%
costing::validate_sbor_payload 29.3±0.05µs 30.2±0.21µs +3.07%
costing::validate_sbor_payload_bytes 254.5±0.47ns 246.1±1.16ns -3.30%
costing::validate_secp256k1 76.6±0.04µs 76.6±0.08µs 0.00%
costing::validate_wasm 34.6±0.03ms 34.0±0.06ms -1.73%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 220.2±1.07ns 217.2±0.33ns -1.36%
decimal::add/wasmi-call-native 2.1±0.01µs 2.1±0.01µs 0.00%
decimal::div/0 168.2±0.13ns 168.7±0.10ns +0.30%
decimal::from_string/0 156.7±0.07ns 156.1±0.15ns -0.38%
decimal::mul/0 128.4±0.07ns 130.0±0.28ns +1.25%
decimal::mul/rust-native 128.9±0.09ns 127.1±0.06ns -1.40%
decimal::mul/wasmi 12.0±0.12µs 11.5±0.05µs -4.17%
decimal::mul/wasmi-call-native 2.2±0.01µs 2.2±0.01µs 0.00%
decimal::pow/0 595.3±1.35ns 596.2±0.41ns +0.15%
decimal::pow/rust-native 591.1±0.24ns 592.2±0.24ns +0.19%
decimal::pow/wasmi 60.1±0.58µs 58.5±0.41µs -2.66%
decimal::pow/wasmi-call-native 3.2±0.02µs 3.2±0.00µs 0.00%
decimal::root/0 8.0±0.01µs 8.1±0.01µs +1.25%
decimal::sub/0 8.2±0.00ns 8.2±0.00ns 0.00%
decimal::to_string/0 439.9±0.44ns 438.6±0.17ns -0.30%
large_transaction_processing::prepare 2.5±0.00ms 2.6±0.00ms +4.00%
large_transaction_processing::prepare_and_decompile 6.3±0.02ms 6.2±0.03ms -1.59%
large_transaction_processing::prepare_and_decompile_and_recompile 32.5±0.38ms 29.2±2.70ms -10.15%
metadata_validation::validate_urls 4.9±0.02µs 5.0±0.03µs +2.04%
precise_decimal::add/0 8.9±0.01ns 8.6±0.00ns -3.37%
precise_decimal::add/rust-native 10.6±0.01ns 10.8±0.09ns +1.89%
precise_decimal::add/wasmi 280.5±0.69ns 283.0±0.83ns +0.89%
precise_decimal::add/wasmi-call-native 2.7±0.02µs 2.9±0.01µs +7.41%
precise_decimal::div/0 313.2±2.40ns 294.9±0.61ns -5.84%
precise_decimal::from_string/0 202.1±0.30ns 203.1±0.28ns +0.49%
precise_decimal::mul/0 350.0±1.64ns 333.8±1.11ns -4.63%
precise_decimal::mul/rust-native 285.1±0.29ns 287.2±0.21ns +0.74%
precise_decimal::mul/wasmi 33.9±0.34µs 33.6±0.28µs -0.88%
precise_decimal::mul/wasmi-call-native 3.1±0.00µs 3.2±0.01µs +3.23%
precise_decimal::pow/0 1761.3±3.63ns 1736.6±2.87ns -1.40%
precise_decimal::pow/rust-native 1365.6±1.39ns 1353.9±1.35ns -0.86%
precise_decimal::pow/wasmi 160.6±0.90µs 162.4±1.68µs +1.12%
precise_decimal::pow/wasmi-call-native 5.3±0.03µs 5.3±0.02µs 0.00%
precise_decimal::root/0 58.1±0.04µs 58.0±0.18µs -0.17%
precise_decimal::sub/0 9.1±0.14ns 8.9±0.13ns -2.20%
precise_decimal::to_string/0 698.8±0.36ns 699.7±0.42ns +0.13%
schema::validate_payload 384.3±0.49µs 378.3±0.27µs -1.56%
transaction::radiswap 4.8±0.02ms 4.8±0.02ms 0.00%
transaction::transfer 1815.8±5.14µs 1799.1±2.88µs -0.92%
transaction_validation::validate_manifest 43.1±0.07µs 43.2±0.05µs +0.23%
transaction_validation::verify_bls_2KB 1011.0±26.62µs 1022.2±33.10µs +1.11%
transaction_validation::verify_bls_32B 1004.5±19.68µs 1017.6±30.28µs +1.30%
transaction_validation::verify_ecdsa 74.6±0.07µs 74.6±0.23µs 0.00%
transaction_validation::verify_ed25519 43.7±0.08µs 45.7±0.08µs +4.58%

@dhedey dhedey force-pushed the tweak/various-markups-cuttlefish branch from 15305c1 to 984f7df Compare November 11, 2024 04:37
@dhedey dhedey marked this pull request as ready for review November 12, 2024 12:43
@dhedey dhedey changed the base branch from tweak/cuttlefish-manifest-representation to develop November 12, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant