feature: Add new assertion instruction models #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker tags |
Benchmark for a93970bClick to view benchmark
|
talekhinezh
approved these changes
Oct 3, 2024
iamyulong
reviewed
Oct 3, 2024
| LowerBound::Inclusive(decimal) => *decimal, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Doesn't seem correct to me with the ONE. Also, why not LowerBound(Decimal)?
There was a problem hiding this comment.
Well Omar was the one advocating for it, but actually I think it makes sense to capture the intention of the caller with e.g. NonZero.
e.g. NonZero for a divisibility 18 Fungible means "at-least one atto", but for a Non-Fungible is actually "at least one". In practice, we interpret NonZero to mean "an infinitesimal amount" when interpreting it as a lower bound.
| match self { | ||
| ManifestResourceConstraint::NonZeroAmount => true, | ||
| ManifestResourceConstraint::ExactAmount(amount) => !amount.is_negative(), | ||
| ManifestResourceConstraint::AtLeastAmount(amount) => !amount.is_negative(), |
There was a problem hiding this comment.
Minor: do we want to restrict granularity to 1?
There was a problem hiding this comment.
Nice idea, have added these constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the following instruction models, including compilation, decompilation and validation:
ASSERT_WORKTOP_RESOURCES_ONLYASSERT_WORKTOP_RESOURCES_INCLUDEASSERT_NEXT_CALL_RETURNS_ONLYASSERT_NEXT_CALL_RETURNS_INCLUDEASSERT_BUCKET_CONTENTSAlso:
ASSERT_WORKTOP_IS_EMPTY, to be an instruction alias.e2e.rsto properly format the error messages, making debugging much easier.Further work
Testing
e2e.rsstatic_resource_movements_visitor.rs