Updated scrypto dependency to latest version #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xOmarA
reviewed
Apr 29, 2024
crates/radix-engine-toolkit/src/transaction_types/traverser/types/general.rs
Outdated
Show resolved
Hide resolved
0xOmarA
reviewed
Apr 29, 2024
0xOmarA
reviewed
Apr 29, 2024
0xOmarA
reviewed
Apr 29, 2024
| @@ -1056,24 +1055,24 @@ macro_rules! manifest_args { | |||
| ($($args: expr),*$(,)?) => {{ | |||
| use ::sbor::Encoder; | |||
| let mut buf = ::sbor::rust::vec::Vec::new(); | |||
| let mut encoder = radix_engine_common::data::manifest::ManifestEncoder::new( | |||
| let mut encoder = radix_common::data::manifest::ManifestEncoder::new( | |||
There was a problem hiding this comment.
Can you please add support for the account locker methods to the builder? Examples of how we've done this in the past is at the end of the file.
Please let me know if you think that this should be a separate PR to get this in quicker for Lukasz.
There was a problem hiding this comment.
I've added all of the AccountLocker blueprint functions, but there is an issue with account_locker_airdrop in Swift error: Address does not conform to protocol Hashable
There was a problem hiding this comment.
I've solved this issue by making the HashMap's key a string. Will need to look into getting a Hashable address soon.
Feature/decimal to from bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update Scrypto dependency to latest version required for:
Decimalto/from bytes (PR Feature/decimal to from bytes #118)zeroizeonPrivateKeySpecial attention to:
Lockerblueprint addition andVersionedSchemachanges.