remove trailing slash #997
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractFruitFactory
force-pushed
the
PTD-1253-console-remove-trailing-from-claimed-websites-in-configure-metadata-page
branch
from
c325461
to
79881fd
Compare
|
|
Docker tags |
| @@ -37,7 +37,7 @@ | |||
| if (isValidUrl(value)) { | |||
| http | |||
| .post('api/claimed-website', { | |||
| url: value, | |||
| url: value.endsWith('/') ? value.slice(0, -1) : value, | |||
There was a problem hiding this comment.
Unfortunately, the intention was to show validation error rather than silently change it for the user
For the developer console, I don't think we should be silently trying to make corrections like this. What the user enters is what is used. If there's a problem, we should show errors, but the user should fix themselves.
link
There was a problem hiding this comment.
also, this is not about checking it's status but rather what we put in the manifest and I don't see any changes about that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.