Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource aggregate rework #792

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Resource aggregate rework #792

merged 8 commits into from
Oct 3, 2024

Conversation

PawelPawelec-RDX
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-database-migrations:HEAD-776feb0-arm64

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-gateway-api:HEAD-776feb0-arm64

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-data-aggregator:HEAD-776feb0-arm64

@PawelPawelec-RDX PawelPawelec-RDX changed the title Resource aggregate rework rebased Resource aggregate rework Sep 17, 2024
@PawelPawelec-RDX PawelPawelec-RDX marked this pull request as ready for review September 17, 2024 13:28
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-aggregate-rework-rebase branch 3 times, most recently from 7613f71 to c93a6a3 Compare September 17, 2024 15:03
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the resource-aggregate-rework-rebase branch 2 times, most recently from 6f39e9c to e4a73df Compare September 27, 2024 12:48
dhedey
dhedey approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! 👍 Query logic looks good I think 💯

A few minor code style/naming/code moving suggestions, but nothing critical.

Happy for you to merge when you're happy.

src/RadixDlt.NetworkGateway.PostgresIntegration/Queries/EntityFungibleResourcesQuery.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/Queries/EntityFungibleResourcesQuery.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/Queries/EntityFungibleResourcesQuery.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/Queries/EntityFungibleResourcesQuery.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/Queries/EntityFungibleResourcesQuery.cs Outdated Show resolved Hide resolved
src/RadixDlt.NetworkGateway.PostgresIntegration/Queries/ResourceSupplyQuery.cs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@PawelPawelec-RDX PawelPawelec-RDX merged commit 3717a17 into develop Oct 3, 2024
15 of 16 checks passed
@PawelPawelec-RDX PawelPawelec-RDX deleted the resource-aggregate-rework-rebase branch October 3, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhedey dhedey dhedey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PawelPawelec-RDX @dhedey @krzlabrdx