Make ErrorDetails into a pointer

[superbeeny]

Description

Replacement PR for #8163

[radius-functional-tests]

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	superbeeny/radius
Commit ref	d663b06
Unique ID	func820d5f3567
Image tag	pr-func820d5f3567

Click here to see the list of tools in the current test run

• gotestsum 1.12.0
• KinD: v0.20.0
• Dapr:
• Azure KeyVault CSI driver: 1.4.2
• Azure Workload identity webhook: 1.3.0
• Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func820d5f3567
• Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
• applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func820d5f3567
• dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func820d5f3567
• controller test image location: ghcr.io/radius-project/dev/controller:pr-func820d5f3567
• ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func820d5f3567
• deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

[codecov]

Codecov Report

Attention: Patch coverage is 41.81818% with 32 lines in your changes missing coverage. Please review.

Project coverage is 59.94%. Comparing base (835abb0) to head (d663b06).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/armrpc/rest/results.go	7.69%	12 Missing ⚠️
pkg/armrpc/frontend/server/handler.go	50.00%	3 Missing ⚠️
pkg/ucp/frontend/controller/radius/proxy.go	0.00%	3 Missing ⚠️
...corerp/frontend/controller/containers/validator.go	84.61%	2 Missing ⚠️
...d/controller/awsproxy/deleteawsresourcewithpost.go	0.00%	2 Missing ⚠️
...tend/controller/awsproxy/getawsresourcewithpost.go	0.00%	2 Missing ⚠️
pkg/armrpc/api/v1/errorresponse.go	0.00%	1 Missing ⚠️
pkg/armrpc/authentication/certvalidator.go	0.00%	1 Missing ⚠️
pkg/ucp/aws/errorhandler.go	0.00%	1 Missing ⚠️
pkg/ucp/frontend/controller/awsproxy/awsparsing.go	50.00%	1 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8367      +/-   ##
==========================================
- Coverage   59.94%   59.94%   -0.01%     
==========================================
  Files         596      596              
  Lines       40432    40432              
==========================================
- Hits        24238    24235       -3     
- Misses      14367    14369       +2     
- Partials     1827     1828       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kachawla]

Looks good to me. Thanks @superbeeny. Could you update the PR title to be explicit about change? (just good practice and clearer for release notes)

[superbeeny]

Done @kachawla :)