Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Explicit Section for Prerequisites #1385

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

kachawla
Copy link
Contributor

@kachawla kachawla commented Feb 5, 2025

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Egde version of Radius CLI installation requires Oras as a prerequisite. Currently it is bundled with rest of the content and is easy to miss until you hit an error while trying to install Radius CLI.

Issue reference

Sorry, something went wrong.

@@ -10,6 +10,9 @@ Radius consists of a set of tools and services that together form the Radius pla

{{< image src="radius.png" alt="Diagram showing rad CLI and VSCode extension on local machine plus the Radius control plane on a Kubernetes cluster" width="600px" >}}

## Prerequisites
For edge version, Oras installation is required: https://oras.land/docs/installation.

## Step 1: Install the rad CLI

{{< read file= "/shared-content/installation/rad-cli/install-rad-cli.md" >}}
Copy link
Contributor Author

@kachawla kachawla Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it from step 1 https://github.com/radius-project/docs/blob/edge/docs/shared-content/installation/rad-cli/install-rad-cli.md?plain=1#L12 in next commit, if this structure looks good. Direct edit link on the docs website doesn't allow updating multiple files at once.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to remove it from step 1 in https://github.com/radius-project/docs/blob/edge/docs/shared-content/installation/rad-cli/install-rad-cli.md?plain=1#L12 as the structure there is already set up such that the Oras prerequisite is only required in the edge version tab. It doesn't hurt to remind users again that they need Oras once they visit the edge tab within that page.

@willtsai
Copy link
Contributor

please address spelling check before merging, thanks!

Egde version of Radius CLI installation requires Oras as a prerequisite. Currently it is bundled with rest of the content and is easy to miss until you hit an error while trying to install Radius CLI.

Signed-off-by: Karishma Chawla <[email protected]>
@kachawla
Copy link
Contributor Author

please address spelling check before merging, thanks!

Updated. Thanks for the review.

Signed-off-by: Karishma Chawla <[email protected]>
@kachawla kachawla force-pushed the kachawla-cli-install-docs branch from b8dfa98 to 20723d4 Compare February 26, 2025 23:21
@kachawla kachawla merged commit 7cf44ab into edge Feb 27, 2025
9 checks passed
@kachawla kachawla deleted the kachawla-cli-install-docs branch February 27, 2025 22:01
ytimocin pushed a commit that referenced this pull request Mar 4, 2025
* Add Explicit Section for Prerequisites

Egde version of Radius CLI installation requires Oras as a prerequisite. Currently it is bundled with rest of the content and is easy to miss until you hit an error while trying to install Radius CLI.

Signed-off-by: Karishma Chawla <[email protected]>

* Ignore Oras from spellchecking

Signed-off-by: Karishma Chawla <[email protected]>

---------

Signed-off-by: Karishma Chawla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants