Skip to content

Commit

Permalink
fix(types): make min_duration, max_duration, and isrc_country optional (
Browse files Browse the repository at this point in the history
  • Loading branch information
hairmare authored Mar 25, 2024
1 parent b2c44e6 commit e962e3b
Show file tree
Hide file tree
Showing 5 changed files with 79 additions and 125 deletions.
12 changes: 3 additions & 9 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,11 @@
repos:
- repo: local
hooks:
- id: black
name: black
language: system
entry: black
types: [python]
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: 'v0.3.2'
rev: v0.3.4
hooks:
- id: ruff
- id: ruff-format
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v3.4.0
rev: v4.5.0
hooks:
- id: trailing-whitespace
exclude: ^src/api/client.js$
Expand Down
8 changes: 5 additions & 3 deletions acrclient/models.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
"""Models for acr-client."""

from __future__ import annotations

from typing import TypedDict


Expand All @@ -10,9 +12,9 @@ class GetBmCsProjectsResultsParams(TypedDict): # pragma: no cover
"""last: get the last results, day: get the day results, Default is day"""
date: str
"""Get all the results on this date. The format is YYYYmmdd (E.g. 20210201)"""
min_duration: int
min_duration: int | None
"""Return the results of played_duration >= min_duration seconds (default: 0)"""
max_duration: int
max_duration: int | None
"""Return results with played_duration <= max_duration seconds (default: 3600)"""
isrc_country: str
isrc_country: str | None
"""Only return results that match the isrc country code (E.g. DE, FR, IT, US)"""
Loading

0 comments on commit e962e3b

Please sign in to comment.