-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Show from nowplaypadgen project #132
Draft
hairmare
wants to merge
12
commits into
radiorabe:main
Choose a base branch
from
hairmare:chore/use-show-from-nowplaypadgen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: use Show from nowplaypadgen project #132
hairmare
wants to merge
12
commits into
radiorabe:main
from
hairmare:chore/use-show-from-nowplaypadgen
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairmare
force-pushed
the
chore/use-show-from-nowplaypadgen
branch
from
December 26, 2021 17:25
dbb13b6
to
d2faacb
Compare
3 tasks
hairmare
force-pushed
the
chore/use-show-from-nowplaypadgen
branch
from
January 18, 2022 22:41
0f36d90
to
46e0073
Compare
This reverts commit e41558c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft is a first step and i'll likely end up completely replacing the local
Show
class with the one from nowplaypadgen.The main things that still need to be taken care of for that to happen are
Fixes #8 partially