Bugfix for touch panning in WPF #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pulationStarted, so the Core.mouseDown and Core.mouseCurrent were never initialized for the touch manipulation. This resulted in eg. a sudden movement as soon as a user touched a single finger on the GMapControl. Added a separate touchCurrent variable for keeping track of the accumulated touch pan operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was no handler for OnManipulationStarted, so the Core.mouseDown and Core.mouseCurrent were never initialized for the touch manipulation. This resulted in eg. a sudden movement as soon as a user touched a single finger on the GMapControl.
Added a separate touchCurrent variable for keeping track of the accumulated touch pan operation, to prevent problems if some event changes the mouseCurrent during the touch manipulation operation.
WPF also has separate fields for the accumulated translation, which could simplify the code quite a bit. However, that would mean a breaking change in the interface of SingleTouchPanMap, and I'm not sure how you feel about that. Would you prefer that version?