Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressbar: switch to tqdm, add description #913

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

keflavich
Copy link
Contributor

As in the title: there are a lot of progressbars scattered throughout spectral-cube, and it can be tricky to track down where they are. Adding labels should help.

@keflavich keflavich requested a review from astrofrog June 16, 2024 18:52
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but can't we just require tqdm as a dependency as it's so lightweight? This will then simplify the code in utils.py and fix the CI.

@keflavich
Copy link
Contributor Author

I'm OK with that. @e-koch, you good with just making tqdm a requirement?

@e-koch
Copy link
Contributor

e-koch commented Sep 5, 2024

agreed. as Tom points out, it's lightweight and simplifies things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants