WIP: Cubewcs mosaic and dask reproject #894
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
force-pushed
the
cubewcs_mosaic_and_dask_reproject
branch
from
5bc5a6c
to
cca08dc
Compare
e-koch
reviewed
Dec 19, 2023
spectral_cube/cube_utils.py
Outdated
| if specw1.wcs.cdelt == 1.0: | ||
| raise NotImplementedError("Spectral WCS doesn't have a CDELT parameter; we don't know how to deal with this generally.") | ||
| if np.sign(specw1.wcs.cdelt) == 1: | ||
| new_crval3 = ranges.min().to(u.Hz).value |
There was a problem hiding this comment.
Keep in the same spectral unit?
Suggested change
| new_crval3 = ranges.min().to(u.Hz).value | |
| new_crval3 = ranges.min().value |
There was a problem hiding this comment.
CRVAL has to be in Hz - astropy wcs (wcslib) will force it to be if it isn't
There was a problem hiding this comment.
I don't think this is the case, or only is when the spectral axis is already in freq. If it's velocity, the default is to m/s.
I added a couple commits that restructure this part to ensure it inherits the appropriate default WCS spectral unit (and this fixed our existing mosaic tests in this PR for me).
e-koch
reviewed
Dec 19, 2023
WIP / stash
add missing import
import import
…(but it doesn't work right yet)
… add a lot of verbosity
bugfix in weight handling bugfix in weight handling
…should be semiautomatically excluded
…d CRVAL fixed while increasing NAXIS adds a bunch of useless blank pixels
keflavich
force-pushed
the
cubewcs_mosaic_and_dask_reproject
branch
from
5290d36
to
bbb71a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is associated with astropy/reproject#351 and enables cube mosaicing with memory mapping. It might also work with astropy/reproject#388, but that's unclear.