-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Cubewcs mosaic and dask reproject #894
Open
keflavich
wants to merge
87
commits into
radio-astro-tools:master
Choose a base branch
from
keflavich:cubewcs_mosaic_and_dask_reproject
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Cubewcs mosaic and dask reproject #894
keflavich
wants to merge
87
commits into
radio-astro-tools:master
from
keflavich:cubewcs_mosaic_and_dask_reproject
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5bc5a6c
to
cca08dc
Compare
e-koch
reviewed
Dec 19, 2023
e-koch
reviewed
Dec 19, 2023
5290d36
to
bbb71a1
Compare
26a1aba
to
c636655
Compare
WIP / stash
add missing import
import import
…(but it doesn't work right yet)
… add a lot of verbosity
8320826
to
14fa698
Compare
…es instead of 1-chan slices
…orner case. There are no default cases.
I've been commenting on #868 with my work on this PR. This PR now depends on astropy/reproject#474 |
interesting, the tests are failing on CI with an 'unterminated string error' that is simply incorrect; the code runs fine, so it is syntactically correct. I'll get rid of it, though. |
Tests now pass locally. CI won't pass until we can hook up to astropy/reproject#474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is associated with astropy/reproject#351 and enables cube mosaicing with memory mapping. It might also work with astropy/reproject#388, but that's unclear.