MNT: Clean up _astropy_init.py #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because config stuff is unnecessary and removed in astropy v6.0
|
Failure is unrelated. Looks like you need to clean up your CI infrastructure, which is out of scope here. |
Codecov ReportAll modified lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
@astrofrog @e-koch I'm good to merge this, even with CI red, as long as we're confident we're not using it. We do need to update CI elsewhere. |
|
Agreed on merging now and fixing the CI issue elsewhere. |
|
PSA: You might wanna release before astropy v6.0 comes out at the end of the year. See https://github.com/astropy/astropy/wiki/Release-Calendar |
|
Thanks for the merge! |
This was referenced Oct 12, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because config stuff is unnecessary and removed in astropy v6.0, see:
And I don't think you even use it anyway?
This is failing our devdeps job in Jdaviz CI (e.g., spacetelescope/jdaviz#2409) because even though Jdaviz does not use this package, glue-astronomy refuses to make this package optional.
cc @astrofrog @keflavich