Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve plot_channel_maps by adding parameters for the usage of colorbar #662

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

improve plot_channel_maps by adding parameters for the usage of colorbar #662

wants to merge 3 commits into from

Conversation

Jiangxuejian
Copy link

add three parameters for plot_channel_maps so that one can plot and adjust a color bar for the channel maps.

@Jiangxuejian
Update spectral_cube.py
34f8b8d 
add three parameters for plot_channel_maps so that one can plot and adjust a color bar for the channel maps.
@Jiangxuejian Jiangxuejian changed the title Update spectral_cube.py improve plot_channel_maps by adding parameters for the usage of colorbar Sep 3, 2020
@coveralls
Copy link

coveralls commented Sep 3, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 85.947% when pulling 34f8b8d on Jiangxuejian:patch-1 into 1497c07 on radio-astro-tools:master.

keflavich
keflavich requested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a helpful addition.

If you don't specify vmin/vmax, this colorbar will only be appropriate for the final panel, right? We perhaps should force that vmin/vmax or norm are specified if the colorbar is included.

spectral_cube/spectral_cube.py Outdated Show resolved Hide resolved
spectral_cube/spectral_cube.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keflavich keflavich keflavich requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiangxuejian @coveralls @keflavich