Fix most memory leaks problems in t/local/36_verify.t reported by Assress Sanitize #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set1_name is not documented and has leak in OpenSSL code, it can\'t be fixed in Net:SSLeay code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build perl (and consequently Net::SSLleay) using Address Sanitizer, t/local/36_verify.t test will fail.
This patch properly frees objects that needs to be freed explicitly, and makes Address Sanitizer happy.
The only one remaining problem
X509_VERIFY_PARAM_set1_namefunction that is undocumented function of OpenSSL and it has memory leak by design: it doparam->name = OPENSSL_strdup(name);andX509_VERIFY_PARAM_freedoes not try to free it. So I would suggest to remove this function from the test case and documentation: same way they did in OpenSSL.You can find instruction on how to build perl in this modulet using ASan in #469
PS please refer me as NATARAJ (Nikolay Shaplov) if you ever would like to mention me anywhere.