GH-452 Expose OpenSSL initialisation and deinitialisation functions #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Expose multiple functions related to OpenSSL initialisation and deinitialisation. Add new test file 23_openssl_init.t for the newly exposed functions.
OpenSSL 3.0 added atexit() handler that appears to cause crashes with test 62_threads-ctx_new-deadlock.t. The test is now updated to initialise OpenSSL libcrypto so that atexit() handler is not called. As a result, OpenSSL libraries are no longer cleaned up on exit. This is fine for the test since the process that runs it is already exiting and the test requires no special cleaning up.
Fix the #if compilation guard to use correct OpenSSL version. SSL_SESSION_get0_cipher is added by OpenSSL 1.1.0.
…crypto. OPENSSL_INIT_NO_ATEXIT was added in OpenSSL 1.1.1b, therefore we need to check for its presence rather than OPENSSL_init_crypto that was added during OpenSSL 1.1.0 development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose OpenSSL initialisation and deinitialisation functions
OPENSSL_init_cryptoandOPENSSL_init_ssland their related functions. These functions were first added in OpenSSL 1.1.0 and are available when the automatic default library initialisation needs to be overridden.Starting with Openssl 3.0.0 it seems that Net::SSLeay test
62_threads-ctx_new-deadlock.tneeds to overrideatexit()handler to avoid crashes that happen after the test has successfully finished and the process is exiting.Closes #452