GH-425 and GH-438 Update SSLeay.xs to support C++ compilers #451
+27
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om 'void *'. C allows implicit pointer conversion to and from 'void *'. C++ does not allow this. Support C++ compilers by avoiding implicit conversion or by adding explicit cast to where conversion is needed.
…l to 'char *. In C string literals do not have the 'const' qualifier but in C++ they do. Avoid C++ compiler warnings by changing our TRACE() funciton definition to use 'const char *' instead of plain 'char *'. This is a useful change for C too because they string passed to the function can be expected to be read-only.
'extern "C" {}' block has wrapped Perl XS standard includes since the
beginning. The earliest version found from the net is Net_SSLeay.pm version
0.4 in which the following was already present:
#ifdef __cplusplus
extern "C" {
#endif
#include "EXTERN.h"
#include "perl.h"
#include "XSUB.h"
#ifdef __cplusplus
}
#endif
This has been carried over since then, until the recent SSLeay.xs updates to
allow compilation with a C++ compiler caused a compilation failure.
Recent GCC and Clang C++ compilers do not care about the 'extern "C"' wrapper
but Visual Studio Community 2022 flagged the following error (see GH-438):
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\wspiapi.h(53):
error C2894: templates cannot be declared to have 'C ' linkage
When 'extern "C" {}' is removed completely, the compilation succeeds. This
makes sense since apparently the purpose of 'extern "C" {}' is to wrap one's
own functions instead of headers included from elsewhere. Those headers should
have their own 'extern "C" {}' definitions, if any are needed.
h-vn
force-pushed
the
GH-425-cpp-patch
branch
from
4f43fbc to
7def5e5
Compare
This was referenced Dec 10, 2023
Closed
This was
linked to
issues
Dec 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl can be built with a C++ compiler and therefore it's useful to update SSLeay.xs so that it can be built with a C++ compiler too. This PR does exactly this. See #425 and #438 for more information.