fix #7152 new "canvas" app for lattice code comparisons #7265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
moellep
commented
Sep 19, 2024
moellep
commented
- adds h5 input beam file support to elegant and mad-x
- includes an alpha version of the impactx app
- the fix for #7264 wasn't quite right
e-carlin
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
I clicked around the apps that were changed and all looked good.
One thing I saw but I'm not sure I understand the app entirely: If I disable one of the codes in the canvas app I still see their output in the reports. Ex. disable madx but a madx phase space plot is still shown.
|
Yes, that's right - the code selection isn't implemented yet, so all codes get run always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.