Use corfu--initial-state instead of corfu--initial-state #159
Conversation
|
This seems to work for me. Thank you for making this pull request. @raxod, how do you want to handle the changed variable? Do you want the Prescient code to still work with the older variable until a new stable version of Corfu is published (which this PR currently does)? |
|
That seems prudent, if the change was recent, then people might be using either the new version or the old version. Unless it's difficult, it makes sense to me to support both. Of course, it goes without saying that it'd be nice if there were a public interface exposed that could be used instead. |
|
Currently, the package dependencies are as follows: ;; Package-Requires: ((emacs "27.1") (prescient "6.1.0") (corfu "0.28"))Corfu has been released 10 times since |
- If `corfu--state-vars` is not bound, use the new `corfu--initial-state` instead. - Bump the required Corfu version from 0.28 to 1.1. Once the next stable version is released, we can bump it again and remove references to the old variable. - Update the changelog. See: - Corfu commit 63d1de2696adcb09a4ea01ba668635364e37a9c2 (minad/corfu@63d1de2) - This PR radian-software#159. - Prescient issue radian-software#158, reporting this change.
okamsn
force-pushed
the
fix/corf-initial-state
branch
from
1cb4fb3
to
4671df6
Compare
I think that Emacs treats the I have merged the PR. Thanks to those that created the issue and thank you for providing the fix. |
|
@okamsn Thanks for improving and merging! |
Fixes #158
I don't have a good understanding of corfu and prescient, so I haven't confirmed that they work properly. This patch may be insufficient. In that case, please feel free to close this PR.