Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address recommendations from Stefan Monnier and others #142

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Address recommendations from Stefan Monnier and others #142

wants to merge 1 commit into from

Conversation

okamsn
Copy link
Contributor

@okamsn okamsn commented Dec 25, 2022

As discussed in #138.

@okamsn okamsn marked this pull request as draft December 25, 2022 19:54
raxod502
raxod502 reviewed Dec 30, 2022
View reviewed changes
Copy link
Member

@raxod502 raxod502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with all these changes. If there's something you'd like me to take a look at to provide historical context or advice, let me know, but as long as the user-facing behavior remains pretty similar to before, it sounds good to me.

@okamsn okamsn force-pushed the address-recommendations branch 2 times, most recently from aab3ae4 to 99a399f Compare July 25, 2023 23:57
@okamsn
Address recommendations of Stefan Monnier for adding to Non-GNU ELPA.
4e29b4f 
These recommendations were made to better support the ELPA method of
fetching and delivering packages (expecting one package per repo)
and of testing builds (not erroring for the optional dependencies of
the now single package).

- Make `require` not signal an error if missing Vertico, Corfu, or
  Company.
- Use `featurep` to detect whether requirements are installed.
- Add ELPA-generated files to `gitignore`.
- Improve declarations and add more.
  - Mark external packages with "ext" in `declare-function`.
- Remove package requirements from the extension files.
- Add `prescient-pkg.el`.
  - Adding the file to the repo (instead of ELPA generating it) seems to
    work better for testing.
  - Remove version information and package requirements from the
    individual extension files.

  These two changes allow the command `package-install-from-buffer` in a
  Dired buffer to work better. No other changes to the files' preambles
  seem needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raxod502 raxod502 raxod502 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okamsn @raxod502