-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add parseHumanDuration
and defineHumanQuantityParser
functions
#332
Open
hugo082
wants to merge
5
commits into
radashi-org:main
Choose a base branch
from
hugo082:parse-human-duration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarlonPassos-git
suggested changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
A few observations:
- Then run the
pnpm format
command. (It seems that we have a problem with the CI, where it doesn't throw a formatting error, I'll take a look later 😅) - Create a file with the bentchmaks.
- And then update the
next-minor.md
file with the changes from the PR
Benchmark Results
Performance regressions of 30% or more should be investigated, unless they were anticipated. Smaller regressions may be due to normal variability, as we don't use dedicated CI infrastructure. |
|
MarlonPassos-git
approved these changes
Dec 27, 2024
MarlonPassos-git
added
the
new feature
This PR adds a new function or extends an existing one
label
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement
parseHumanDuration
anddefineHumanQuantityParser
functionsRelated issue, if any:
Related discussion
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/number/parseHumanDuration.ts
Footnotes
Function size includes the
import
dependencies of the function. ↩