feat: add withSemaphore & withMutex function
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugo082
changed the title
withSemaphore functionwithSemaphore & withMutex function
MarlonPassos-git
added
the
new feature
aleclarson
reviewed
Jan 5, 2025
Comment on lines
+30
to
+32
| * const limitedFn = withMutex(() => ...) | ||
| * limitedFn() | ||
| * limitedFn(() => ...) |
There was a problem hiding this comment.
This usage is not supported by the current type definitions. I assume we'll want to update this example, rather than allow overriding the base function?
aleclarson
reviewed
Jan 5, 2025
Comment on lines
+69
to
+71
| * const limitedFn = withSemaphore({ capacity: 2 }, () => ...) | ||
| * limitedFn() | ||
| * limitedFn(() => ...) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
withSemaphorefunction which creates a semaphoreRelated issue, if any:
Related discussion
For any code change,
Does this PR introduce a breaking change?
No
In addition
I struggled to initialize the function via the radashi cli because of
No radashi dependency found in package.jsonerror.https://app.warp.dev/block/FMHVZF6RUhM2jAIiADsEUR
Bundle impact
src/async/withMutex.tssrc/async/withSemaphore.tsFootnotes
Function size includes the
importdependencies of the function. ↩