test(isEqual): add order-agnostic cases for Set and Map #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blafasel3
changed the title
Blafasel3
changed the title
|
Thanks for the PR and welcome to the Radashi community! It would be great to remove the bash dependency if possible, as bash is used very little. I wrongly assumed bash existed everywhere. I suppose I could just rewrite the node_modules check directly into the Node.js scripts. 🤔 |
aleclarson
changed the title
MarlonPassos-git
pushed a commit
to MarlonPassos-git/radashi
that referenced
this pull request
Nov 10, 2024
) Co-authored-by: Max Lenhardt <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 2 already succeeding test cases for Javascript Sets and Maps to further ensure that
isEqualworks as expected. The test cases assure that Maps and Sets are compared agnostic of insertion order.Related issue, if any:
Adding testcases for Sets and Maps agnostic of insertion order
For any code change,
Does this PR introduce a breaking change?
No
I'm currently NOT running on a linux machine and cannot run the linting due to the bash dependecy. I will try to install wsl soon but wont be able to do it now.