Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix runtime errors in docs examples for playground #247

Conversation

MarlonPassos-git
Copy link
Contributor

@MarlonPassos-git MarlonPassos-git commented Sep 16, 2024

Tip

The owner of this PR can publish a preview release by commenting /publish in this PR. Afterward, anyone can try it by running pnpm add radashi@pr<PR_NUMBER>.

Summary

This PR resolves the issue mentioned in Discussion #207 by fixing runtime errors in several code examples across the docs/ folder. This fix ensures that all documented examples will now run as expected.

Related issue, if any:

Fixes #207

For any code change,

  • Documentation has been updated, if needed
  • Tests have been added or updated
  • Benchmarks have been updated, if needed

Does this PR introduce a breaking change?

No

Bundle impact

Status File Size 1 Difference
M src/array/merge.ts 185 -25 (-12%)

Footnotes

  1. Function size includes the import dependencies of the function.

@MarlonPassos-git MarlonPassos-git added the documentation Improvements or additions to documentation label Sep 16, 2024
@aleclarson aleclarson added the priority: high This needs attention soon. label Sep 17, 2024
@aleclarson
Copy link
Member

This is great! I will definitely review this before v12.2.0 is released. 👍

@aleclarson aleclarson force-pushed the bugfix/documentation-examples-erros branch from b9a44f3 to 859c2c4 Compare November 1, 2024 20:48
@aleclarson aleclarson force-pushed the bugfix/documentation-examples-erros branch from 910f24d to 2e324fe Compare November 1, 2024 20:55
@aleclarson aleclarson merged commit b640c2c into radashi-org:main Nov 1, 2024
6 checks passed
MarlonPassos-git added a commit to MarlonPassos-git/radashi that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority: high This needs attention soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants