-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix runtime errors in docs examples for playground #247
Merged
aleclarson
merged 19 commits into
radashi-org:main
from
MarlonPassos-git:bugfix/documentation-examples-erros
Nov 1, 2024
Merged
docs: fix runtime errors in docs examples for playground #247
aleclarson
merged 19 commits into
radashi-org:main
from
MarlonPassos-git:bugfix/documentation-examples-erros
Nov 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarlonPassos-git
added
the
documentation
Improvements or additions to documentation
label
Sep 16, 2024
This is great! I will definitely review this before v12.2.0 is released. 👍 |
aleclarson
force-pushed
the
bugfix/documentation-examples-erros
branch
from
November 1, 2024 20:48
b9a44f3
to
859c2c4
Compare
aleclarson
force-pushed
the
bugfix/documentation-examples-erros
branch
from
November 1, 2024 20:55
910f24d
to
2e324fe
Compare
MarlonPassos-git
added a commit
to MarlonPassos-git/radashi
that referenced
this pull request
Nov 10, 2024
…#247) Co-authored-by: Alec Larson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterward, anyone can try it by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
This PR resolves the issue mentioned in Discussion #207 by fixing runtime errors in several code examples across the docs/ folder. This fix ensures that all documented examples will now run as expected.
Related issue, if any:
Fixes #207
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/array/merge.ts
Footnotes
Function size includes the
import
dependencies of the function. ↩