-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add version reference #246
Merged
aleclarson
merged 126 commits into
radashi-org:main
from
MarlonPassos-git:feature/add-versions
Sep 21, 2024
Merged
docs: add version reference #246
aleclarson
merged 126 commits into
radashi-org:main
from
MarlonPassos-git:feature/add-versions
Sep 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarlonPassos-git
changed the title
docs: add version reference
docs: add version reference
Sep 14, 2024
MarlonPassos-git
added
the
documentation
Improvements or additions to documentation
label
Sep 14, 2024
You are on fire 🔥 This looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
In this PR, I added the
@version
tag in the JSDoc of functions to provide a reference for when each function was introduced.I used the file
radashi/dist/esm/index.mjs
from npm as a base to identify which functions were available in version12.1.0
. For functions that were not present in that version, I assigned them the12.2.0
tag. Although version12.2.0
has not been released yet, I decided to add the tag in advance to maintain consistency with "official" versions.Additionally, I updated the
.mdx
files by adding a newsince
property. This will allow us to integrate this information into the documentation project later on.I plan to open a follow-up PR in the documentation project with my suggestions for incorporating this information.
As a side note, I used a workaround script to assist in generating the changes:
addVersionInTsFile.cjs
addVersionInTsFile.cjs
Related issue, if any:
#243 (comment)
radashi-org/radashi-org.github.io#3
For any code change,
Does this PR introduce a breaking change?
No