Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update set_version.sh to work with beta versions #423

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update set_version.sh to work with beta versions #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2603de5
update set_version.sh to work with beta versions
ShiCheng-Lu Dec 11, 2024
1a73733
use #define for sdk version
ShiCheng-Lu Dec 11, 2024
da8db32
note that version should be left alone as a define
gregsadetsky Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion RadarSDK/RadarUtils.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@

#import "RadarUtils.h"

// the version below should be left as a define/string literal to allow for easy replacement using set_version.shf
#define SDK_VERSION @"3.19.5"

@implementation RadarUtils

static NSDateFormatter *_isoDateFormatter;
Expand Down Expand Up @@ -45,7 +48,7 @@ + (NSNumber *)timeZoneOffset {
}

+ (NSString *)sdkVersion {
return @"3.19.5-beta.1";
return SDK_VERSION;
}

+ (NSString *)deviceId {
Expand Down
2 changes: 1 addition & 1 deletion set_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ sed_inplace "s/s.version( +)= '(.+)'/s.version\1= '$version_full'/" RadarSDKMoti
sed_inplace "s/MARKETING_VERSION = .+;/MARKETING_VERSION = $version;/" RadarSDK.xcodeproj/project.pbxproj
sed_inplace "s/MARKETING_VERSION = .+;/MARKETING_VERSION = $version;/" RadarSDKMotion/RadarSDKMotion.xcodeproj/project.pbxproj

sed_inplace "s/return @\"[0-9]+\.[0-9]+\.[0-9]+\";/return @\"$version_full\";/" RadarSDK/RadarUtils.m
sed_inplace "s/#define SDK_VERSION @\".+\"/#define SDK_VERSION @\"$version_full\"/" RadarSDK/RadarUtils.m
Loading