Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

short circuit track verified if getConfig fails #393

Merged
merged 3 commits into from
Sep 25, 2024
Merged

short circuit track verified if getConfig fails #393

merged 3 commits into from
Sep 25, 2024

Conversation

KennyHuRadar
Copy link
Contributor

  • fix bug of track verified not returning if getConfig api call fails
  • short circuit the track verified process if getConfig fails, we should not bother performing the rest of the trackVerified

nickpatrick
nickpatrick approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@nickpatrick nickpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Let's test thoroughly before releasing.

Do we also need to make changes on Android?

Suggested release notes:

- Improves `Radar.trackVerified()` error handling.

@KennyHuRadar KennyHuRadar merged commit 801044b into master Sep 25, 2024
1 of 2 checks passed
@KennyHuRadar KennyHuRadar deleted the kenny/short-circuit-tracked-verify-if-get-config-fails branch September 25, 2024 21:46
@ShiCheng-Lu ShiCheng-Lu mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpatrick nickpatrick nickpatrick approved these changes

@lmeier lmeier Awaiting requested review from lmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KennyHuRadar @nickpatrick