Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RadarLogBuffe off main thread #388

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

KennyHuRadar
Copy link
Contributor

@KennyHuRadar KennyHuRadar commented Aug 30, 2024

Resource intensive actions should be performed off the main thread per Apple's suggestions.
This PR may seeks to migrate such tasks off the main thread where it may potentially cause freezing of the UI.
The target of migration is the RadarLogBuffer.

@KennyHuRadar KennyHuRadar changed the title Migrate radar location manager and logging off main thread Migrate RadarLogBuffer and RadarLocationManager off main thread Nov 18, 2024
@KennyHuRadar
Copy link
Contributor Author

KennyHuRadar commented Nov 18, 2024

To facilitate a quicker ship, we may want to just ship a version of this PR without the changes to the track path.
We suspect that the logging workload is the prime suspect. We can then observe if changes to the track path are still needed.
We may also be confident enough to ship this without a flag with some testing if we only shipped changes to the logging functionality.

@KennyHuRadar KennyHuRadar changed the title Migrate RadarLogBuffer and RadarLocationManager off main thread Migrate RadarLogBuffe off main thread Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant