-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RadarLogBuffe off main thread #388
Open
KennyHuRadar
wants to merge
12
commits into
master
Choose a base branch
from
migrate-radar-location-manager-off-mainthread
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate RadarLogBuffe off main thread #388
KennyHuRadar
wants to merge
12
commits into
master
from
migrate-radar-location-manager-off-mainthread
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion-manager-off-mainthread merging older branch that migrates off main thread for logs
KennyHuRadar
changed the title
Migrate radar location manager and logging off main thread
Migrate RadarLogBuffer and RadarLocationManager off main thread
Nov 18, 2024
To facilitate a quicker ship, we may want to just ship a version of this PR without the changes to the track path. |
KennyHuRadar
changed the title
Migrate RadarLogBuffer and RadarLocationManager off main thread
Migrate RadarLogBuffe off main thread
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource intensive actions should be performed off the main thread per Apple's suggestions.
This PR may seeks to migrate such tasks off the main thread where it may potentially cause freezing of the UI.
The target of migration is the RadarLogBuffer.