validate address should allow addresslabel in place of street + number, fix timezone json conversion issues. #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiCheng-Lu
changed the title
ShiCheng-Lu
commented
Aug 7, 2024
| @@ -56,7 +67,7 @@ - (NSDictionary *)dictionaryValue { | |||
| dict[@"_id"] = self._id; | |||
| dict[@"name"] = self.name; | |||
| dict[@"code"] = self.code; | |||
| dict[@"currentTime"] = self.currentTime; | |||
| dict[@"currentTime"] = [timezoneDateFormatter() stringFromDate:self.currentTime]; | |||
There was a problem hiding this comment.
the current time string from server is a different format (no millisecond) so we need a different parser than RadarUtils.isoDateFormatter
ShiCheng-Lu
commented
Aug 7, 2024
| @@ -89,7 +89,7 @@ - (NSDictionary *)dictionaryValue { | |||
| dict[kDestinationGeofenceTag] = self.destinationGeofenceTag; | |||
| dict[kDestinationGeofenceExternalId] = self.destinationGeofenceExternalId; | |||
| dict[kMode] = [Radar stringForMode:self.mode]; | |||
| dict[kScheduledArrivalAt] = self.scheduledArrivalAt; | |||
There was a problem hiding this comment.
NSDate object does not get converted, this field was null, format it to string since all our other date formats are converted to string with JSON
| @@ -8,6 +8,16 @@ | |||
| #import "RadarTimeZone.h" | |||
| #import "RadarUtils.h" | |||
|
|
|||
| NSDateFormatter *_timezoneDateFormatter = nil; | |||
There was a problem hiding this comment.
Probably there no action items for with respect to this PR, but we really should consider having a more "central" place where we define our time parsers. There are quite a few definitions littered around the codebase. Just a call out to keep in mind for the future.
…d-allow-addresslabel-in-addition-to
KennyHuRadar
approved these changes
Sep 26, 2024
…d-allow-addresslabel-in-addition-to
…d-allow-addresslabel-in-addition-to
…d-allow-addresslabel-in-addition-to
ShiCheng-Lu
deleted the
shicheng/fence-2045-validate-address-should-allow-addresslabel-in-addition-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/radarlabs/issue/FENCE-2045/validate-address-should-allow-addresslabel-in-addition-to-street
also:
https://linear.app/radarlabs/issue/FENCE-2044/some-dictionaryvalues-does-not-convert-nsdate-to-string-properly
all tested with example app with each producing the correct outputs when converted to JSON.