Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #37 #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

javatenor
Copy link

A minimum changes to fix issue #37:

  • updated Sonar version in main pom.xml to 6.0
  • replaced deprecated @BatchSide -annotation in org.sonar.plugins.json.api.CustomJSONRulesDefinition with @ScannerSide -annotation
  • changed unittest org.sonar.plugins.json.JSONPluginTest to work with updated Sonar version

@racodond
Copy link
Owner

Hi @javatenor,

Thanks for the PR.
I don't want to keep maintaining this plugin: https://github.com/racodond/sonar-json-plugin#disclaimer
So, feel free to fork and take over.

Thank you

David

@javatenor
Copy link
Author

javatenor commented Dec 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants