Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable termination protection for stacks that fail to create #2739

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ITProKyle
Copy link
Collaborator

@ITProKyle ITProKyle commented Jan 30, 2025

Summary

When using termination protection, if a stack fails to create (first deployment of a stack) termination protection must be manually disabled. This change enables CFNgin to disable termination protection for stacks that fail to create (not update).

resolves #2395

Why This Is Needed

Removes the need for termination protection to be disabled prior deploying stacks that previously failed to create.

What Changed

Changed

  • CFNgin can now disable termination protection automatically for stacks that fail to create

Fixed

  • fixed issue requiring manual intervention when a stack fails during initial creation

@ITProKyle ITProKyle added bug Something isn't working changelog:minor Minor change resulting in a minor release labels Jan 30, 2025
@ITProKyle ITProKyle added this to the v2.8 milestone Jan 30, 2025
@ITProKyle ITProKyle self-assigned this Jan 30, 2025
@github-actions github-actions bot added the changelog:patch Patch change resulting in a patch release label Jan 30, 2025
@ITProKyle ITProKyle removed the changelog:minor Minor change resulting in a minor release label Jan 30, 2025
@ITProKyle ITProKyle enabled auto-merge (squash) January 30, 2025 21:12
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (fdf4ed7) to head (cdc2d10).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2739   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         256      256           
  Lines       15820    15826    +6     
=======================================
+ Hits        14288    14294    +6     
  Misses       1532     1532           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ITProKyle ITProKyle merged commit 3c5667b into master Jan 30, 2025
24 checks passed
@ITProKyle ITProKyle deleted the fix/disable-protect-failed-stack branch January 30, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:patch Patch change resulting in a patch release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Disable termination protection for stacks that fail to create.
2 participants