-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Resyntax fixes #1429
Open
resyntax-ci
wants to merge
19
commits into
master
Choose a base branch
from
autofix-20-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Automated Resyntax fixes #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
The `null?` predicate can be used to test for the empty list.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `match` expression can be simplified using `match-define`.
This `if` expression can be refactored to an equivalent expression using `and`.
The `define` form supports a shorthand for defining functions.
The `syntax-disarm` function is a legacy function that does nothing.
Only one of the `for/fold` expression's result values is used. Use the `#:result` keyword to return just that result.
The `append-map` function can be used to map each element into multiple elements in a single pass.
The `else`-`if` branch of this `cond` expression can be collapsed into the `cond` expression.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This quasiquotation is equialent to a simple `list` call.
This expression is equivalent to calling the `negative?` predicate.
This negated `when` expression can be replaced by an `unless` expression.
This `if` expression can be refactored to an equivalent expression using `and`.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if`-`else` chain can be converted to a `cond` expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 20 files.
let-to-define
single-clause-match-to-match-define
define-lambda-to-define
cond-let-to-cond-define
if-else-false-to-and
nested-if-to-cond
map-to-for
cond-else-if-to-cond
quasiquote-to-list
define-simple-macro-to-define-syntax-parse-rule
for/fold-result-keyword
append*-and-map-to-append-map
equal-null-list-to-null-predicate
always-throwing-if-to-when
inverted-when
zero-comparison-to-negative?
syntax-disarm-migration