Automated Resyntax fixes #1426
Open
Automated Resyntax fixes #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This `match` expression can be simplified using `match-define`.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Using `cond` instead of `if` here makes `begin` unnecessary
This `if` expression can be refactored to an equivalent expression using `and`.
This `map` operation can be replaced with a `for/list` loop.
The `define` form supports a shorthand for defining functions.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This variable is returned immediately and can be inlined.
This `let` expression can be pulled up into a `define` expression.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
sorawee
reviewed
Jan 10, 2025
| (list p*-base | ||
| p*-name | ||
| (if (places) | ||
| (delay/thread (begin0 (run-in-other-place p* error?) |
There was a problem hiding this comment.
This should be fixed in fmt
There was a problem hiding this comment.
Fixed in sorawee/fmt#84. @jackfirth, is it possible to re-run Resyntax?
sorawee
reviewed
Jan 10, 2025
| (delay/thread (begin0 (run-in-other-place p* error?) | ||
| (when (zero? (modulo i 10)) | ||
| (eprintf ".")))) | ||
| (delay (parameterize ([read-accept-reader #t] |
sorawee
reviewed
Jan 10, 2025
| (if (s-exn? res) | ||
| (raise (deserialize-exn res)) | ||
| res)] | ||
| (when (s-exn? res) |
sorawee
added a commit
to sorawee/fmt
that referenced
this pull request
Jan 10, 2025
Fixing poor formatting in racket/typed-racket#1426
sorawee
added a commit
to sorawee/fmt
that referenced
this pull request
Jan 10, 2025
Fixing poor formatting in racket/typed-racket#1426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 50 issues in 14 files.
single-clause-match-to-match-definelet-to-definealways-throwing-if-to-wheninline-unnecessary-defineif-let-to-condif-else-false-to-anddefine-let-to-double-defineif-begin-to-condmap-to-fordefine-lambda-to-define