Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #1416

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #1416

wants to merge 16 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Nov 29, 2024

Resyntax fixed 44 issues in 20 files.

  • Fixed 13 occurrences of tidy-require
  • Fixed 7 occurrences of single-clause-match-to-match-define
  • Fixed 7 occurrences of let-to-define
  • Fixed 3 occurrences of let-values-then-call-to-call-with-values
  • Fixed 2 occurrences of define-simple-macro-to-define-syntax-parse-rule
  • Fixed 2 occurrences of sort-with-keyed-comparator-to-sort-by-key
  • Fixed 2 occurrences of zero-comparison-to-positive?
  • Fixed 1 occurrence of case-lambda-with-single-case-to-lambda
  • Fixed 1 occurrence of if-begin-to-cond
  • Fixed 1 occurrence of inverted-when
  • Fixed 1 occurrence of define-lambda-to-define
  • Fixed 1 occurrence of cond-let-to-cond-define
  • Fixed 1 occurrence of inverted-unless
  • Fixed 1 occurrence of begin0-let-to-define-begin0
  • Fixed 1 occurrence of if-else-false-to-and

resyntax-ci bot added 16 commits November 29, 2024 00:31
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if` expression can be refactored to an equivalent expression using `and`.
This `match` expression can be simplified using `match-define`.
Keep imports in `require` sorted and grouped by phase, with collections before files.
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
This expression is equivalent to calling the `positive?` predicate.
The `define` form supports a shorthand for defining functions.
This `let-values` expression can be replaced with a simpler, equivalent `call-with-values` expression.
This negated `unless` expression can be replaced by a `when` expression.
Using `cond` instead of `if` here makes `begin` unnecessary
The `let` expression in this `begin0` form can be extracted into the surrounding definition context.
This `case-lambda` form only has one case. Use a regular lambda instead.
This `sort` expression can be replaced with a simpler, equivalent expression.
This negated `when` expression can be replaced by an `unless` expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants