Partly revert d53a197 & 36fc539 to workaround #233 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To workaround racket#233, this partly reverts commits - "highlight universe when set-up fails at run-time". d53a197 - "fix resource administration in run and launch-many-worlds". 36fc539 Otherwise, when the object `[((new-world (if #,rec? aworld% world%)) w #,@Args)]` and `[((new-universe universe%) u #,@Args)]` are created in the main thread, the continuation marks of the stepper are somehow broken. A more appropriate fix should be applied in the future.
In big-bang tests, if the tick frequency is high, some to-draw steps (e.g. the one immediately following the launch of big-bang) can be absent in stepper because no such call are made. This commit adds the `(repetition ,lo ,hi ,steps) form to stepper tests to account for skippable steps.
shhyou
force-pushed
the
thread-big-bang
branch
from
e5c320c to
d2412ac
Compare
|
@jbclements This change is intended to be merged after the branch day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more appropriate fix should be applied in the future.
To workaround #233, this partly reverts commits
Otherwise, when the object
[((new-world (if #,rec? aworld% world%)) w #,@args)]and[((new-universe universe%) u #,@args)]are created in the main thread, the continuation marks of the stepper are somehow broken.The two follow up commits forward the
check-withexceptions from(o)inesp/thdto the main thread and repackages it withbig-bang's stack frames.