Optimize UDP packet statistics collection and clear hashstring in Packet::onlySource() #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using this in my program on ubuntu, and recently I found that it can not show the pid of udp packets sometimes, then I look up the code carefully, and found it may concerned about the conninode_udp which got from /proc/net/udp, the rem_address in this file is sometimes empty, so the hashstring saved in conninode_udp sometimes may not accurate(only have source address), and when use conninode_udp in getProcess, the value somethimes may could't found, cause the hash key here is the full(which has both source addr and dest addr extracted from the info captured from libpcap), so it was added to the unknownudp; I think its inapposite, maybe use onlySource as key is better here?
Also, I've found that in Packet::onlySource(), the hashstring of new packet is forgot to release.
Hope this helps. Best regards.