Update documentation to cover both new and classic config formats #161
Conversation
Other guides will be gradually migrated to use both formats later.
| <pre class="example"> | ||
| %% advanced.config | ||
| %% See HTTP backend docs for details | ||
| {rabbitmq_auth_backend_http, |
There was a problem hiding this comment.
http.user_path
http.vhost_path
http.resource_path
are defined in http backend plugin schema rabbitmq/rabbitmq-auth-backend-http@571937f
will look like
http.user_path = http://my-authenticator-app/auth/user
http.vhost_path = http://my-authenticator-app/auth/vhost
http.resource_path = http://my-authenticator-app/auth/resource
| documentation</a>. | ||
| <p>Default: <code>[]</code></p> | ||
| <p>Default: <code>none</code></p> |
There was a problem hiding this comment.
If none is defined, none of other options will work.
For example:
ssl_options = none
ssl_options.verify = verify_peer
Equivalent to
ssl_options = none
There was a problem hiding this comment.
The only idea I have is to set "undefined", which can lead to exactly the same problem. Yeah, I don't think many will fall into this trap.
There was a problem hiding this comment.
To be consistent with other examples, you should recall the parameter:
<p>Default: <code>ssl_options = none</code></p>
|
@michaelklishin: do we want |
|
@hairyhum I think it would be helpful in case someone uncomments/uses the default value unintentionally. |
|
for |
|
So it's better to leave it without |
| loopback_users = none | ||
| </pre> | ||
|
|
||
| Or, in the <a href="/configure.html#erlang-term-config-file">classic config file format</a> (<code>rabbitmq.config</code>): |
There was a problem hiding this comment.
I would use "legacy" instead of "classic" to designate the old file formar.
There was a problem hiding this comment.
We still support this format, and it is still used in the advanced config. It would be odd to call something legacy and then use it for both backwards compatibility and advanced cases.
| @@ -105,7 +105,7 @@ Or using classic config format: | |||
|
|
|||
| <pre class="code"> | |||
| listeners.tcp.1 = 127.0.0.1:5672 | |||
| listeners.tcp.2 = ::1:5672 | |||
| listeners.tcp.2 = [::1]:5672 | |||
There was a problem hiding this comment.
This should be added to example snippets in rabbitmq_tests
There was a problem hiding this comment.
I've added it and waiting for the test suite to finish.
There was a problem hiding this comment.
I reverted that change due to basho/cuttlefish#216. We'll work on that later.
This reverts commit 1a06ba5. Due to basho/cuttlefish#216. We will deal with that later. FWIW values such as ::1:5672 parse successfully.
| @@ -83,12 +83,18 @@ Disabling disk free space monitoring</pre> | |||
| required to be free on the database partition. (See the description of | |||
| <a href="/relocate.html">file locations</a> for the default location). | |||
There was a problem hiding this comment.
I'm not sure from the context here what the "default location" is referring to. Is it the free disk space limit?
There was a problem hiding this comment.
Default database location.
On 22 mar 2016, at 21:48, Brandon Shroyer [email protected] wrote:
In site/disk-alarms.xml:
@@ -83,12 +83,18 @@ Disabling disk free space monitoring
required to be free on the database partition. (See the description of
file locations for the default location).
I'm not sure from the context here what the "default location" is referring to. Is it the free disk space limit?—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
Remove unnecessary to_i in worker.rb in ruby tutorials
Updates the docs for http://github.com/rabbitmq/rabbitmq-server/issues/550.