Use prelaunch context instead of reading app env. variable #10018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
use-context-instead-of-application-env
branch
2 times, most recently
from
7719665 to
9a54ad3
Compare
[Why]
We use the application environment as some kind of "cache" for the
configuration parameters and some system environment variables. However,
because we don't use `sys.config`, the application environment could be
reset to its default/empty state if we were to use Erlang releases.
[How]
For values that may come from the system environment, we use the
prelaunch context instead.
V2: If the value is unavailable from the context, we fall back to the
application environment variable. We still need this for the CLI and
some testsuites.
... instead of reading an application environment variable directly. [Why] There an API to abrastract already, let's use it.
dumbbell
force-pushed
the
use-context-instead-of-application-env
branch
from
9a54ad3 to
c10c232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We use the application environment as some kind of "cache" for the configuration parameters and some system environment variables. However, because we don't use
sys.config, the application environment could be reset to its default/empty state if we were to use Erlang releases.How
For values that may come from the system environment, we use the prelaunch context instead.