Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOOST-4672] implement flexible fee structures for QuestBudget #291

Merged
merged 32 commits into from
Sep 16, 2024
Merged

[BOOST-4672] implement flexible fee structures for QuestBudget #291

merged 32 commits into from
Sep 16, 2024

Commits on Sep 10, 2024

  1. feat(QuestBudget): add management fee and quest managers mapping

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7c183cc View commit details
    Browse the repository at this point in the history

  2. feat: update available function to account for reserved funds

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    883925b View commit details
    Browse the repository at this point in the history

  3. feat: add IERC20 import to QuestBudget contract

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5a63122 View commit details
    Browse the repository at this point in the history

  4. feat: add management fee functionality to QuestBudget

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    cbf2e30 View commit details
    Browse the repository at this point in the history

  5. feat(QuestBudget): add management fee handling in quest creation

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    088843e View commit details
    Browse the repository at this point in the history

  6. feat(QuestBudget): add management fee claim functionality

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    107f0bc View commit details
    Browse the repository at this point in the history

  7. test: add tests for setManagementFee function

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1929c52 View commit details
    Browse the repository at this point in the history

  8. test: add test for createERC20Quest with management fee

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9d1d4e2 View commit details
    Browse the repository at this point in the history

  9. docs(QuestBudget): fix comment formatting in payManagementFee

    @mmackz
    mmackz committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ae5f02e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. test(QuestBudget): add test for insufficient funds scenario

    @mmackz
    mmackz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fae037a View commit details
    Browse the repository at this point in the history

  2. test: add test for initial management fee value

    @mmackz
    mmackz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    53fdde7 View commit details
    Browse the repository at this point in the history

  3. test(QuestBudget): refactor comments

    @mmackz
    mmackz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8f410ae View commit details
    Browse the repository at this point in the history

  4. test: update management fee calculation in tests

    @mmackz
    mmackz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c48f380 View commit details
    Browse the repository at this point in the history

  5. test: add management fee payment test case

    @mmackz
    mmackz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    edd9c66 View commit details
    Browse the repository at this point in the history

  6. chore: format

    @mmackz
    mmackz committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a5f709f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. refactor: use common quest parameters in tests

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6824356 View commit details
    Browse the repository at this point in the history

  2. refactor(mock): rename questData and add mapping function

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    aca9bb3 View commit details
    Browse the repository at this point in the history

  3. feat(test): add helper function to set mock quest data

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b5da1f6 View commit details
    Browse the repository at this point in the history

  4. test(QuestBudget): add tests for payManagementFee function

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2199da0 View commit details
    Browse the repository at this point in the history

  5. test: add test for unauthorized management fee payment

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e2e91db View commit details
    Browse the repository at this point in the history

  6. test(QuestBudget): update management fee assertion check

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c12755b View commit details
    Browse the repository at this point in the history

  7. test(QuestBudget): add test for not quest creator condition

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a11d4da View commit details
    Browse the repository at this point in the history

  8. test: add test for management fee insufficient funds scenario

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    578820b View commit details
    Browse the repository at this point in the history

  9. test: add test for partial participants management fee

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d53f2ae View commit details
    Browse the repository at this point in the history

  10. test(QuestBudget): add tests for management fee payment event

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c1f71cd View commit details
    Browse the repository at this point in the history

  11. feat(test): add ManagementFeeSet event to tests

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    94c82ec View commit details
    Browse the repository at this point in the history

  12. test(QuestBudget): add test for reserved funds behavior

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c341593 View commit details
    Browse the repository at this point in the history

  13. test: Refactor quest creation to use structured data

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ab0439c View commit details
    Browse the repository at this point in the history

  14. refactor: use budget owner address in assertion

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    498bea5 View commit details
    Browse the repository at this point in the history

  15. style: Update documentation for management fee event

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ac8087f View commit details
    Browse the repository at this point in the history

  16. test: Update quest setup comments and withdrawal state

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    be6fa60 View commit details
    Browse the repository at this point in the history

  17. refactor: give more descriptive namesand add natspec comments to helpers

    @mmackz
    mmackz committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3019b12 View commit details
    Browse the repository at this point in the history