Deploy on zk-sync #152
Closed
Deploy on zk-sync #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
I was able to get this deployed, but we were having errors deploying a quest, I noted the error here: zkSync-Community-Hub/zksync-developers#97 It might be because of contract size. We decided not to deploy on ZKSync for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we are blocked on this because zksync has two issues:
We can't deploy minimal proxies: zkSync-Community-Hub/zksync-developers#91
We can't deploy contracts from other contracts: zkSync-Community-Hub/zksync-developers#97
Also it looks like the foundry version is having issues also: matter-labs/foundry-zksync#113