Move questNFT to a 1155 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+101
to
+111
| function mint(address to_, string memory questId_) | ||
| public | ||
| onlyMinter questChecks(questId_) whenNotPaused nonReentrant | ||
| { | ||
| QuestData storage quest = quests[questId_]; | ||
|
|
||
| _mint(to_, quest.tokenId, 1, ""); | ||
|
|
||
| (bool success, ) = protocolFeeRecipient.call{value: quest.questFee}(""); | ||
| require(success, 'protocol fee transfer failed'); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls
contracts/QuestNFT.sol
Outdated
Comment on lines
74
to
99
| function addQuest( | ||
| uint256 questFee_, | ||
| uint256 startTime_, | ||
| uint256 endTime_, | ||
| uint256 totalParticipants_, | ||
| string memory questId_, | ||
| string memory description_, | ||
| string memory imageIPFSHash_ | ||
| ) public onlyMinter returns (uint256) { | ||
| require (endTime_ > block.timestamp, 'endTime_ in the past'); | ||
| require (startTime_ > block.timestamp, 'startTime_ in the past'); | ||
| require (endTime_ > startTime_, 'startTime_ before endTime_'); | ||
|
|
||
| _tokenIdCounter.increment(); | ||
| QuestData storage quest = quests[questId_]; | ||
| quest.startTime = startTime_; | ||
| quest.endTime = endTime_; | ||
| quest.totalParticipants = totalParticipants_; | ||
| quest.questFee = questFee_; | ||
| quest.imageIPFSHash = imageIPFSHash_; | ||
| quest.description = description_; | ||
| quest.tokenId = _tokenIdCounter.current(); | ||
| tokenIdToQuestId[_tokenIdCounter.current()] = questId_; | ||
|
|
||
| return _tokenIdCounter.current(); | ||
| } |
Check notice
Code scanning / Slither
Block timestamp
contracts/QuestNFT.sol
Outdated
| @@ -15,73 +16,53 @@ import {ReentrancyGuardUpgradeable} from "@openzeppelin/contracts-upgradeable/se | |||
| /// @title QuestNFT | |||
| /// @author RabbitHole.gg | |||
| /// @notice This contract is the Erc721 Quest Completion contract. It is the NFT that can be minted after a quest is completed. | |||
There was a problem hiding this comment.
Should update this comment to use 1155
contracts/QuestNFT.sol
Outdated
| string memory imageIPFSHash_ | ||
| ) public onlyMinter returns (uint256) { | ||
| require (endTime_ > block.timestamp, 'endTime_ in the past'); | ||
| require (startTime_ > block.timestamp, 'startTime_ in the past'); |
There was a problem hiding this comment.
Should we remove this check? I believe we removed it in Quest.sol so that we can start quests immediately
There was a problem hiding this comment.
Oh yes, we removed the start time checks when creating a quest here: 9a3556a
Good point, I'll remove it.
jonathandiep
approved these changes
Jun 23, 2023
Closed
Comment on lines
+100
to
+110
| function mint(address to_, string memory questId_) | ||
| public | ||
| onlyMinter questChecks(questId_) whenNotPaused nonReentrant | ||
| { | ||
| QuestData storage quest = quests[questId_]; | ||
|
|
||
| _mint(to_, quest.tokenId, 1, ""); | ||
|
|
||
| (bool success, ) = protocolFeeRecipient.call{value: quest.questFee}(""); | ||
| require(success, 'protocol fee transfer failed'); | ||
| } |
Check warning
Code scanning / Slither
Unchecked low-level calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the NFTQuest type from an ERC721 to an ERC1155 type. When an erc1155 is created we call this a collection. A collection can have many quests which map to token ids in the 1155. The flow is this:
Quest creator:
QuestFactory.createCollectionQuestFactory.addQuestToCollectionQuest completer:
QuestFactory.mintQuestNFTAnd we have some handy functions for the frontend to use:
QuestFactory.ownerCollectionsByOwnerreturns all the collections given an user address. This will be useful because a user can choose to either use an existing collection or create a new one when creating a NFT type quest.