filter empty sql

Signed-off-by: ⚆ Trung Nguyen <[email protected]>
r2dbc · Jan 4, 2024 · 6b83671 · 6b83671
1 parent 3531c15
commit 6b83671
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/src/main/java/io/r2dbc/h2/H2Statement.java b/src/main/java/io/r2dbc/h2/H2Statement.java
@@ -102,6 +102,7 @@ public Flux<H2Result> execute() {
         Assert.requireTrue(!this.bindings.open, "No unfinished bindings!");
 
         return Flux.fromArray(this.sql.split(";"))
+            .filter(sql -> !sql.trim().isEmpty())
             .flatMap(sql -> {
                 if (this.generatedColumns == null) {
                     return execute(this.client, sql.trim(), this.bindings, this.codecs, this.allGeneratedColumns);

diff --git a/src/test/java/io/r2dbc/h2/H2StatementTest.java b/src/test/java/io/r2dbc/h2/H2StatementTest.java
@@ -216,6 +216,36 @@ void executeWithoutAdd() {
             .verifyComplete();
     }
 
+    @Test
+    void executeMultipleCommands() {
+        CommandInterface insertCommand1 = mock(CommandInterface.class);
+        when(this.client.prepareCommand("insert test-query-1", Collections.emptyList())).thenReturn(Collections.singleton(insertCommand1).iterator());
+        when(this.client.update(insertCommand1, false)).thenReturn(new ResultWithGeneratedKeys.WithKeys(0, new LocalResult()));
+
+        CommandInterface insertCommand2 = mock(CommandInterface.class);
+        when(this.client.prepareCommand("insert test-query-2", Collections.emptyList())).thenReturn(Collections.singleton(insertCommand2).iterator());
+        when(this.client.update(insertCommand2, false)).thenReturn(new ResultWithGeneratedKeys.WithKeys(0, new LocalResult()));
+
+        new H2Statement(this.client, this.codecs, "insert test-query-1;insert test-query-2")
+            .execute()
+            .as(StepVerifier::create)
+            .expectNextCount(2)
+            .verifyComplete();
+    }
+
+    @Test
+    void executeMultipleCommandsIgnoringEmptyOne() {
+        CommandInterface command = mock(CommandInterface.class);
+        when(this.client.prepareCommand("insert test-query-1", Collections.emptyList())).thenReturn(Collections.singleton(command).iterator());
+        when(this.client.update(command, false)).thenReturn(new ResultWithGeneratedKeys.WithKeys(0, new LocalResult()));
+
+        new H2Statement(this.client, this.codecs, "insert test-query-1;\n  ")
+            .execute()
+            .as(StepVerifier::create)
+            .expectNextCount(1)
+            .verifyComplete();
+    }
+
     @Test
     void returnGeneratedValues() {
         CommandInterface command = mock(CommandInterface.class);