-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new parachain): show polkadot version #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weezy20
reviewed
Mar 30, 2024
test: fix mismatch type error
Daanvdplas
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CinematicCow, amazing to see you again!
weezy20
suggested changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach looks good.
- Iterator should be in reverse order to search starting from latest release
fetch_tag
and all consumers should return and expect an Option, in case the regex fails or template source doesn't use tags.
AlexD10S
reviewed
Apr 2, 2024
AlexD10S
approved these changes
Apr 3, 2024
weezy20
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves for #37. It fetches the latest tag from the repo that is cloned based on the template flag. The release tags are as follows:
As each repo has it's own naming schema, how do we standardize the naming convention for the end user?
Also I saw there is already a function to get the release tag
Github::get_latest_release
using github's api, but that function was async and I am not familiar with async rust. Hope this PR helps :)