Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new parachain): show polkadot version #89

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

CinematicCow
Copy link
Contributor

This PR solves for #37. It fetches the latest tag from the repo that is cloned based on the template flag. The release tags are as follows:

Template Tag
base polkadot-v1.9.0
contract v0.9.0
frontier polkadot-v0.9.37

As each repo has it's own naming schema, how do we standardize the naming convention for the end user?

Also I saw there is already a function to get the release tag Github::get_latest_release using github's api, but that function was async and I am not familiar with async rust. Hope this PR helps :)

Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CinematicCow, amazing to see you again!

src/helpers.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@weezy20 weezy20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good.

  1. Iterator should be in reverse order to search starting from latest release
  2. fetch_tag and all consumers should return and expect an Option, in case the regex fails or template source doesn't use tags.

src/helpers.rs Outdated Show resolved Hide resolved
src/helpers.rs Outdated Show resolved Hide resolved
src/engines/parachain_engine.rs Show resolved Hide resolved
@AlexD10S AlexD10S merged commit 3bbe617 into r0gue-io:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants