-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(up): bump fallback versions #393
Conversation
not sure if still good to review, but out of curiosity, any reason not to kickoff another release in our polkadot fork to use 2412? |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
- Coverage 75.64% 75.62% -0.02%
==========================================
Files 59 59
Lines 12715 12706 -9
Branches 12715 12706 -9
==========================================
- Hits 9618 9609 -9
Misses 1801 1801
Partials 1296 1296
|
These are only the fallback versions in case it cant connect to GH - e.g. rate limited. It should still check for a newer version if it exists. No reason not to kick off the stable2412 release, will give it a go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment. But I am going to approve as I am sure there is a reason for the 2407 and I don't want my timezone to block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Bumps the fallback versions of the relay, parachains and chain specs.