Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(up): bump fallback versions #393

Merged
merged 2 commits into from
Dec 19, 2024
Merged

refactor(up): bump fallback versions #393

merged 2 commits into from
Dec 19, 2024

Conversation

evilrobot-01
Copy link
Contributor

Bumps the fallback versions of the relay, parachains and chain specs.

@peterwht
Copy link
Contributor

not sure if still good to review, but out of curiosity, any reason not to kickoff another release in our polkadot fork to use 2412?

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.62%. Comparing base (e1bfbc8) to head (82e1322).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-parachains/src/up/mod.rs 88.88% 0 Missing and 3 partials ⚠️
crates/pop-parachains/src/up/relay.rs 60.00% 0 Missing and 2 partials ⚠️
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   75.64%   75.62%   -0.02%     
==========================================
  Files          59       59              
  Lines       12715    12706       -9     
  Branches    12715    12706       -9     
==========================================
- Hits         9618     9609       -9     
  Misses       1801     1801              
  Partials     1296     1296              
Files with missing lines Coverage Δ
crates/pop-parachains/src/up/chain_specs.rs 83.03% <100.00%> (ø)
crates/pop-parachains/src/up/parachains.rs 86.24% <100.00%> (-0.15%) ⬇️
crates/pop-parachains/src/up/relay.rs 85.71% <60.00%> (-0.23%) ⬇️
crates/pop-parachains/src/up/mod.rs 87.39% <88.88%> (-0.04%) ⬇️

@evilrobot-01
Copy link
Contributor Author

not sure if still good to review, but out of curiosity, any reason not to kickoff another release in our polkadot fork to use 2412?

These are only the fallback versions in case it cant connect to GH - e.g. rate limited. It should still check for a newer version if it exists. No reason not to kick off the stable2412 release, will give it a go.

Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. But I am going to approve as I am sure there is a reason for the 2407 and I don't want my timezone to block.

crates/pop-parachains/src/up/mod.rs Show resolved Hide resolved
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlexD10S AlexD10S merged commit 21d02db into main Dec 19, 2024
20 checks passed
@AlexD10S AlexD10S deleted the frank/bump-versions branch December 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants